fix: correctly send configure--watch file deletion cycles #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesayyn
reviewed
Nov 1, 2025
| for _, p := range cs.Paths { | ||
| changes[p] = si | ||
| // Determine if the change is a deletion vs regular change | ||
| if _, err := os.Stat(path.Join(cs.Root, p)); err != nil { |
There was a problem hiding this comment.
isn't this expensive to do in a loop? shouldn't we simply diff prev and current to find what's been deleted?
There was a problem hiding this comment.
This is only the paths in the change set, not the full workspace. We don't actually have the full list of files anywhere in go.
But yes I am worried about it being expensive... did you have any other ideas? I took a quick look but maybe missed something... can watchman tell us these were deletions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
run --watchcan detect deletions based on how the runfiles manifest changes, deletions of source files requires an actual fs-stat to determine if the file still exists.Changes are visible to end-users: no
Test plan