Fix memory leaks caused by nested delays #854
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauch
approved these changes
Oct 8, 2025
|
|
||
| # Do the forced extraction work by combining the two delayed lists above then | ||
| # running extract_from_image on the tuple of delayed futures. | ||
| # Persist at this point uning the number of io workers. |
Contributor
There was a problem hiding this comment.
Can probably remove this comment - since we're now using the semaphores further down the line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are currently huge memory leaks caused by generating delayeds from values in a large dataframe - the entirety of the dataframe gets dragged into the delayed (rather than just the selected rows) which causes memory to explode. This happens in both the forced extraction and new sources steps.
After fixing it, I am able to run the entirety of the galactic data through the pipeline.