Skip to content

Remove unnecessary deps - #17

Open
ashaltu wants to merge 3 commits into
mainfrom
reduce-build-time-from-aws-a
Open

Remove unnecessary deps#17
ashaltu wants to merge 3 commits into
mainfrom
reduce-build-time-from-aws-a

Conversation

@ashaltu

@ashaltu ashaltu commented Dec 13, 2025

Copy link
Copy Markdown
Owner

No description provided.

@ashaltu
ashaltu force-pushed the reduce-build-time-from-aws-a branch from ae5d947 to 3994042 Compare December 13, 2025 22:25
@openhands-ai

openhands-ai Bot commented Dec 13, 2025

Copy link
Copy Markdown

Looks like there are a few issues preventing this PR from being merged!

  • GitHub Actions are failing:
    • Install Smoke Test

If you'd like me to help, just leave a comment, like

@OpenHands please fix the failing actions on PR #17 at branch `reduce-build-time-from-aws-a`

Feel free to include any additional details that might help me get this PR into a better state.

You can manage your notification settings

@ashaltu

ashaltu commented Dec 13, 2025

Copy link
Copy Markdown
Owner Author

@OpenHands please fix the failing actions on PR #17 at branch reduce-build-time-from-aws-a

@openhands-ai

openhands-ai Bot commented Dec 13, 2025

Copy link
Copy Markdown

I'm on it! ashaltu can track my progress at all-hands.dev

- Revert CMakeLists.txt to use FATAL_ERROR instead of building AWS SDK from source
- This prevents extremely long build times in CI environments
- Keep the updated vcpkg install command with core,s3 components
- Fixes failing Install Smoke Test action

Co-authored-by: openhands <openhands@all-hands.dev>
@openhands-ai

openhands-ai Bot commented Dec 14, 2025

Copy link
Copy Markdown

I successfully fixed the failing actions on PR #17 by identifying and resolving the root cause of the Install Smoke Test failure.

The Problem: The CMakeLists.txt had been modified to build AWS SDK from source using FetchContent when the library wasn't found locally. This caused extremely long build times (60+ seconds just for configuration) in CI environments, leading to timeouts and failures in the smoke test workflow.

The Solution: I reverted the CMakeLists.txt to use the original FATAL_ERROR approach when AWS SDK isn't found, which forces proper dependency installation rather than attempting to build from source. This change:

  • Eliminates the long build times that were causing CI failures
  • Maintains the improved vcpkg install command with "aws-sdk-cpp[core,s3]"
  • Preserves all the dependency detection logic for different package managers
  • Updates the error message to reflect the new vcpkg syntax

Changes Made:

  • Removed 21 lines of FetchContent logic for building AWS SDK from source
  • Restored the FATAL_ERROR with clear installation instructions
  • Updated the vcpkg command in the error message to use the new syntax

The fix has been committed and pushed to the branch, which should resolve the failing Install Smoke Test action by ensuring builds complete quickly with proper dependency management.

View full conversation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants