Add failing test for aggregate with parent() + select() + limit() #644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Reproduces a bug where combining select() + limit() with an aggregate that uses parent() in its filter causes SQL error. This bug was found in ash_graphql where GraphQL list queries would automatically trigger this scenario.
jechol
force-pushed
the
test/aggregate-with-parent-filter-bug
branch
from
ae18908 to
e32aba4
Compare
|
🔥 thanks for the repro! |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproduces a bug where combining select() + limit() with an aggregate that uses parent() in its filter causes SQL error.
This bug was found in ash_graphql where GraphQL list queries would automatically trigger this scenario.
Contributor checklist
Leave anything that you believe does not apply unchecked.