Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blog fixed. :') #74

Merged
merged 2 commits into from
Apr 11, 2020
Merged

blog fixed. :') #74

merged 2 commits into from
Apr 11, 2020

Conversation

rohanvtk
Copy link
Collaborator

Please have a look at it. :')

@rohanvtk rohanvtk requested a review from Sc0rpi0n101 November 26, 2019 05:02
Copy link
Member

@vipulgupta2048 vipulgupta2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks,

  • How about we start using Worst use of GitHub CDN (or the best?) #71 for replacing images with links.
  • Are these all the changes that were needed to be done, I remember the previous PR spanning multiple blogs. Let me know.

@rohanvtk
Copy link
Collaborator Author

  • Regarding the first bullet-in I left a comment #71
  • Secondly, the previous PR had fixes for akshat's blog(images source url was wrong) otherwise, all other changes requested have been implemented.

@Sc0rpi0n101
Copy link
Member

Ok, So, the images have been replaced by links. These look fine in GitHub viewer.
But they are not rendering properly on my build.
https://sc0rpi0n101.github.io/blog/post/flash_custom_rom/

@rohanvtk
Copy link
Collaborator Author

rohanvtk commented Jan 2, 2020

What should I do now 😕 ?

@vipulgupta2048
Copy link
Member

@Sc0rpi0n101 I think the images aren't working because you installed the @swarnimarun new theme version for testing & now we have another problem of images breaking. We need to investigate this.

@rohanvtk
Copy link
Collaborator Author

rohanvtk commented Jan 3, 2020

@vipulgupta2048 so will these images show up on the main website if someone merges this PR(I won't 😛)?

@Sc0rpi0n101
Copy link
Member

At this point bro, only the Lord knows what'll happen if someone merges anything 🤣🤣

@vipulgupta2048
Copy link
Member

+10 on that and then a +100 on Hugo being dark magic.

I actually checked out this great blogging framework folks were working in React India, https://shaaijs.tech

@Sc0rpi0n101
Copy link
Member

Alright, now that everything's fixed
merging this now 🚀

@Sc0rpi0n101 Sc0rpi0n101 merged commit f8353a6 into asetalias:master Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants