-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blog fixed. :') #74
blog fixed. :') #74
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks,
- How about we start using Worst use of GitHub CDN (or the best?) #71 for replacing images with links.
- Are these all the changes that were needed to be done, I remember the previous PR spanning multiple blogs. Let me know.
|
Ok, So, the images have been replaced by links. These look fine in GitHub viewer. |
What should I do now 😕 ? |
@Sc0rpi0n101 I think the images aren't working because you installed the @swarnimarun new theme version for testing & now we have another problem of images breaking. We need to investigate this. |
@vipulgupta2048 so will these images show up on the main website if someone merges this PR(I won't 😛)? |
At this point bro, only the Lord knows what'll happen if someone merges anything 🤣🤣 |
+10 on that and then a +100 on Hugo being dark magic. I actually checked out this great blogging framework folks were working in React India, https://shaaijs.tech |
Alright, now that everything's fixed |
Please have a look at it. :')