Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manual deps update #49

Merged
merged 4 commits into from
Feb 13, 2025
Merged

Manual deps update #49

merged 4 commits into from
Feb 13, 2025

Conversation

ensary
Copy link
Contributor

@ensary ensary commented Feb 13, 2025 •
edited
Loading

@ensary ensary requested a review from a team as a code owner February 13, 2025 14:36
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ensary ensary requested review from mikerott and akhalina February 13, 2025 15:16
@ttrann6 ttrann6 requested a review from a team February 13, 2025 15:53
dgduncan
dgduncan approved these changes Feb 13, 2025
View reviewed changes
Copy link

@dgduncan dgduncan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only slight nit is that I think we normally you put the .Phony at the top of the makefile

@ensary ensary merged commit 3aa9c4b into master Feb 13, 2025
3 checks passed
@ensary ensary deleted the manual-deps-update branch February 13, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgduncan dgduncan dgduncan approved these changes

@ItsMeWithTheFace ItsMeWithTheFace ItsMeWithTheFace approved these changes

@ttrann6 ttrann6 ttrann6 approved these changes

@willyjfarrell willyjfarrell Awaiting requested review from willyjfarrell willyjfarrell is a code owner automatically assigned from asecurityteam/secdev

@aureagdm aureagdm Awaiting requested review from aureagdm aureagdm is a code owner automatically assigned from asecurityteam/secdev

@byott byott Awaiting requested review from byott byott is a code owner automatically assigned from asecurityteam/secdev

@mikerott mikerott Awaiting requested review from mikerott

@akhalina akhalina Awaiting requested review from akhalina

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ensary @dgduncan @ItsMeWithTheFace @ttrann6