Merge pull request #34 from asecurityteam/github-actions

GitHub Actions

.github/workflows/golang.yaml

@@ -0,0 +1,27 @@
+on: [push]
+
+jobs:
+  golang:
+    runs-on: ubuntu-latest # we execute everything except make in docker anyway
+    name: GoLang Basics
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+      - name: FS Permissions
+        # workaround for permissions with contaner attempting to create directories
+        run: chmod 777 -R "$(pwd)"
+      - name: Dep
+        run: make dep
+      - name: Lint
+        run: make lint
+      - name: Unit Tests
+        run: make test
+      - name: Integration Tests
+        run: make integration
+      - name: Test Coverage
+        run: make coverage
+      - name: Upload Coverage
+        uses: codecov/codecov-action@v4
+        with:
+          files: .coverage/combined.cover.out
+          token: ${{ secrets.CODECOV_TOKEN }} 

Makefile

@@ -1,6 +1,6 @@
 TAG := $(shell git rev-parse --short HEAD)
 DIR := $(shell pwd -L)
-SDCLI_VERSION :=v1.4.0
+SDCLI_VERSION :=v1.5
 SDCLI=docker run --rm -v "$(DIR):$(DIR)" -w "$(DIR)" asecurityteam/sdcli:$(SDCLI_VERSION)
 
 

messageparser_test.go

@@ -338,6 +338,8 @@ func TestSetField(t *testing.T) {
 			if ok {
 				assert.IsType(t, tt.expectedError, setField(&testObject, tt.field, tt.value))
 			} else {
+				// this will be fixed with switch to https://tip.golang.org/doc/go1.22 with new variables per loop iteration
+				// #nosec G601
 				assert.IsType(t, tt.expectedError, setField(&tt.object, tt.field, tt.value))
 
 			}
@@ -403,6 +405,8 @@ func TestAppendToSlice(t *testing.T) {
 			if ok {
 				assert.IsType(t, tt.expectedError, appendToSlice(&testObject, tt.field, tt.value))
 			} else {
+				// this will be fixed with switch to https://tip.golang.org/doc/go1.22 with new variables per loop iteration
+				// #nosec G601
 				assert.IsType(t, tt.expectedError, appendToSlice(&tt.object, tt.field, tt.value))
 
 			}
@@ -468,6 +472,8 @@ func TestAddToMap(t *testing.T) {
 			if ok {
 				assert.IsType(t, tt.expectedError, addToMap(&testObject, tt.field, "key", tt.value))
 			} else {
+				// this will be fixed with switch to https://tip.golang.org/doc/go1.22 with new variables per loop iteration
+				// #nosec G601
 				assert.IsType(t, tt.expectedError, addToMap(&tt.object, tt.field, "key", tt.value))
 			}
 		})