fix: use os.PathListSeparator #2195
Open
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use os.PathListSeparator instead of ":". This removes one blocker for a Windows port as the path separator on Windows is ";". Also use filepath.SplitList instead of strings.Split to correctly handle the (very unepected) case of an empty PATH in RemoveFromPath.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use
os.PathListSeparatorinstead of":". This removes one blocker for a Windows port (#450) as the path separator on Windows is";".Also use
path/filepath.SplitListinstead ofstrings.Splitto correctly handle the (very unexpected) case of an emptyPATHininternal/shims.RemoveFromPath.