-
Notifications
You must be signed in to change notification settings - Fork 3
Example: Decompressing raw data #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jhunkeler
wants to merge
19
commits into
asdf-format:main
Choose a base branch
from
jhunkeler:cmake-compression-experiment-with-example
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Example: Decompressing raw data #68
jhunkeler
wants to merge
19
commits into
asdf-format:main
from
jhunkeler:cmake-compression-experiment-with-example
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* New defines: HAVE_[BZIP2,LZ4,ZLIB]
* Necessary for [de]compression of raw data # Conflicts: # include/asdf/core/ndarray.h
* Example(s) will be build if the cmake option BUILD_EXAMPLES is enabled * Example binaries are not installed
* Compression related HAVE_* defines are now set by the compiler, not the config header.
* Instead of returning the entire block structure, expose enough header information to decompress a buffer
* This can be done wherever the compression code lives
…cmake function" This reverts commit 3001d03.
* find_package() does not always set [NAME]_FOUND for some reason
Contributor
Author
Always something ™️ |
Contributor
Author
|
float.h math.h Test caseflt_eval_method.c #include <float.h>
#include <math.h>
#include <stdio.h>
int main(int argc, char *argv[]) {
printf("__FLT_EVAL_METHOD__ = %d\n", __FLT_EVAL_METHOD__);
return 0;
}clanggcc 13gcc 14 |
embray
reviewed
Nov 20, 2025
| } | ||
|
|
||
| // Dump the contents of a ndarray | ||
| static void show_ndarray(const struct asdf_ndarray *ndarray, const void *data, const int method) { |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a pretty useful utility to build into the CLI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference-only