Skip to content

Conversation

Copy link

Copilot AI commented Nov 6, 2025

Users designing sounds must currently locate and click the operator on/off switch in the operator panel. This PR enables toggling operators by clicking their numbers directly in the Algorithm view.

Implementation

AlgoDisplay.h/cpp

  • Track operator number positions during paint() in opPositions[] array
  • Override mouseDown() to detect clicks on operator numbers and toggle via new toggleOperator() method
  • Add bind() to connect to parent editor
  • Use named constants: MAX_OPERATORS, OP_NUMBER_WIDTH, OP_NUMBER_HEIGHT

PluginEditor.h/cpp

  • Add public toggleOperator(int operatorIndex) method to encapsulate operator toggle logic

GlobalEditor.cpp

  • Call algoDisplay->bind(edit) to wire up the connection

Operator Mapping

Display IDs (1-6) map to internal array indices (5-0) via arrayIndex = 6 - displayID, consistent with existing code:

  • AlgoDisplay::displayOp(): opStatus[6-id]
  • OperatorEditor::bind(): internalOp = 5-op

Clickable area is 16×12 pixels per operator number, matching text drawing dimensions.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • esm.ubuntu.com
    • Triggering command: /usr/lib/apt/methods/https (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>It would be very helpful if the operators could be switched on and off directly in the Algorithm view by clicking the operator number.</issue_title>
<issue_description>Although I have no idea how complex User Interface changes are in this project, I will venture to make a request.

Since building a Minidexed, I've been using Dexed to port some of the SY77 sounds.

During the sound design process, I often have to switch Operator strings on and off.

That is, I select the operator in the Algorithm view, search for the Operator On/Off switch, and then switch the operator on or off.

It would be very helpful if the operators could be switched on and off directly in the Algorithm view by clicking the operator number.</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Add functionality to toggle operators in Algorithm view Add operator toggle on click in Algorithm view Nov 6, 2025
Copilot AI requested a review from asb2m10 November 6, 2025 18:03
Copilot finished work on behalf of asb2m10 November 6, 2025 18:03
Copy link
Owner

@asb2m10 asb2m10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are those "codeql" files ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

It would be very helpful if the operators could be switched on and off directly in the Algorithm view by clicking the operator number.

2 participants