Fixes IE and Safari utilizing feature checks #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi can you please squash your commits ? |
|
@asafdav Squashed them down. |
|
Hi @karrde00, you need to push -f after a squash otherwise all of the old commits stay and it leads to issues. there should be only one commit under the commit tab (currently 11) |
|
Thanks again |
Update data type build update Fix for IE9 inserting HTML into file actual fix actual fix forgot the seperator Update data type forgot the seperator Update data type build update Fix for IE9 inserting HTML into file actual fix actual fix forgot the seperator Update data type forgot the seperator
frankmariette
force-pushed
the
master
branch
from
152053b to
c2a3b1c
Compare
|
@asafdav Fixed it. Thanks for the help on the squash. |
|
@asafdav What's the status on this? |
|
curious about the status of this as well. |
|
+1 to merge this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in fixes for IE and Safari. The Safari "fix" just writes the data to a URI and allows it to be saved as a csv with the page source. Didn't want to use a polyfill for flash with the recent vulnerabilities for Flash. While this isn't ideal it is better than nothing. The IE fix was originally created by @BerangereMartin and I modified it to work with the current version of ng-csv.