update pit helpers to support sample_dims#335
Draft
OriolAbril wants to merge 6 commits intoarviz-devs:mainfrom
Draft
update pit helpers to support sample_dims#335OriolAbril wants to merge 6 commits intoarviz-devs:mainfrom
OriolAbril wants to merge 6 commits intoarviz-devs:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #335 +/- ##
==========================================
+ Coverage 84.47% 84.68% +0.21%
==========================================
Files 43 43
Lines 6067 6073 +6
==========================================
+ Hits 5125 5143 +18
+ Misses 942 930 -12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Documentation build overview
Show files changed (16 files in total): 📝 16 modified | ➕ 0 added | ➖ 0 deleted
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The start is a couple fixes to support
sample_dimsincompute_pit_...helpers which I found while working on arviz-devs/arviz-plots#442. Depending on availability I might include the validator updates too so thesample_dimsattr is taken into account inarviz-statstoo.