DOC: Document kwargs for kde across all layers#327
DOC: Document kwargs for kde across all layers#327player3zxcvbnm wants to merge 1 commit intoarviz-devs:mainfrom
Conversation
3f4ea35 to
a4e5722
Compare
4c6de28 to
00f46aa
Compare
src/arviz_stats/base/array.py
Outdated
| weights : array-like, optional | ||
| axis : int, sequence of int or None, default -1 | ||
| density : bool, default True | ||
| density : bool, optional |
There was a problem hiding this comment.
Apologies for missing that one in the cleanup. I've just reverted the density parameter documentation to its original state as well. The PR should be completely clean now—containing only the kde docstring updates.
00f46aa to
ad2cec7
Compare
…togram changes
ad2cec7 to
82fcc04
Compare
|
I edited you PR description. See how the message is much shorter and the relevant information is there (no need to list the changes that are obvious by inspecting the code). Things still missing
|
|
Thanks for the description edits and the feedback! I’m tied up for the next two days, but I'll address the linking and doc structure as soon as I'm back. |
|
Hi @aloctavodia Out of the options you listed, I agree the second option is the cleanest approach. Since I already documented the underlying kwargs (like I realized linking to the dataarray interface here would just create a redundant double-hop for the user trying to find the kwargs, so pointing directly to the array interface creates a clean, single source of truth. Let me know if this approach sounds good to you and I'll push the updates! |
This PR resolves issue #318 by properly documenting the
**kwargspassed to thekdefunction so users know they can use arguments likebwandadaptive.Note on scope: I noticed that other functions in
accessors.py(likerhat,mcse,histogram, etc.) should also be fixed. I kept this PR strictly scoped tokde, we could fix them in a separate PR for them!