Fork Sync #202
Open
Fork Sync #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
* Retrieve FunctionRunData from file * Add FileNotFoundException doc to FromPath
… civil3d projects (#3119) * fixes generic exception handling * some bug fixes * Update ConnectorBindingsAutocadCivil.Receive.cs * whitespace * pr comment fixes * Update ConnectorBindingsAutocadCivil.Receive.cs * isfatal * logger errors * missed todo * Update ConnectorBindingsAutocadCivil.Receive.cs
* Fix warnings on Automate.SDK * Add doc for exceptions and fix styling * Fix failing runner unit test * Fix warnings on Automate SDK test project * Add README for Automate SDK test project * Do not handle fatal errors * Fix grammar on doc * Add typeparamref for TInput * Add property to projects to make CI fail if any warning * Remove NoWarn prop in test project for CA2007
* Resolved warnings in Integration test project * Updated test projects to use newer nunit syntax * Removed Configure Awaits from Unit test project * polish * wtf csharpier... * Changed Cancellation tests to use CatchAsync rather than ThrowsAsync
Performance test project warnings
…ly at zero warnings (#3133) Enforce WarningsAsErrors all projects that have reached zero warnings
… and moved folder structure (#3136) * Upgraded all tests to use new nunit syntax * Moved Objects unit test project to folder * Ci to use STS * small tweaks to assertions
* Adjusted file structure for all namespace warnings * adjusted more namespaces
Deleted ExampleApp
* archicad v27 and arm * ci-tools checkout * update jobs * build fix * cd fix * fix * use correct format specifiers --------- Co-authored-by: József L. Kiss <>
…ounts while loading them from SQLite (#3138) * hotfix(core): SQLite transport to use new connection for updating objects * Reversed reversed dictionary since it was no longer needed
…list will return the first account found in a server running fe1 fe2 (#3141) * fix(gh): Adds serverUrl to AccountList output Adds ability for AccountGoo to cast from a server+userId string (SERVER_URL?u=USER_ID) This ensures the right account is retrieved. * feat(gh): Minor re-structuring of Account list logic * fix(gh): Removed unnecessary using statements * feat(gh): Added small test for account local identifier uniqueness
* fix(dynamo): CA1031 Do not catch general exceptions in Dynamo projects * fix(dyn): Last CA1031 warnings 💥 * fix(dyn): Formatting was wrong 🤷🏼♂️ * fix(dynamo): Upgraded log to fatal
Resolved XML warnings
* fixes * revert to git checkout main * AC25 build fix
…ds, and fields (#3143) * handles obsolete classes and warnings * small naming warn fixes * additional obsolete fixes * fixes deprecated methods and fields in converters * fixes more deprecated in converters * removes errors from some obsolete properties still in use * Update Duct.cs * Update Instance.cs * Update DefaultTraversal.cs
* Logger unit tests * fixed test to reset console stream on teardown * cleaned up tests a little
…ance (#3142) * Set global contexts on LoggerConfiguration instance * Remove empty Logging folder from * Do not enrich with global log context * Set user id into context after configured * Move sentry sdk configuration after logger created * Add isMachineId flag for context of logger --------- Co-authored-by: Alan Rynne <[email protected]>
…ique Analyser codes) for SDK projects (#3148) * Enforce no more warning (Unique Analyser codes) for SDK projects * Resolve warnings in Autocad = RhinoGH * Objects warning * Formatting
* CNX-8589 Archicad Connector UI finalization * progress.Value --------- Co-authored-by: József L. Kiss <>
* desktopbuild false for dotnet publish builds * Fix warnings in Archicad project * Fixed Formatting * Enforce all Level 1 warnings that don't already have violations
Receive slowed down in Archicad 26 Co-authored-by: József L. Kiss <>
Update Directory.Build.props
Later version of System.Text.Json conflicts Using the 7.0.3 version of System.Text.Json in batchuploader SDK is causing conflicts with core
* Frontend2 bool now set on ServerInfo request * Fixed tests * UserServerInfo * trailing / * polish * Get header from front end * Made changes --------- Co-authored-by: Jedd Morgan <[email protected]>
…1 hardcoded (#3159) * fix(core): FE2 support in StreamWrapper.ToString Based on Account.serverInfo.frontend2 first, then matching regex to originalInput, then defaulting to FE1 Also added NotSupportedException for federation models * fix(core): Remove async return from non async tests
…ving (#3170) adds user strings to converter instance conversion to native
* Updated DUI2 * remove comment subscription * Comments * fix comment * VersionUpdate subscription workaround * Dynamo * Fixed issue with collections being modified while enumerating * removed deprecated tests * Marked deprecated true on all legacy subscriptions * using directives
Remove keyboard shortcuts from plugin registration
For POC purposes - implements a fix - needs investigation
* Ensure CI runs on net8 * remove net 7 * bump csharpier for net8 support * ensure net8 sdk is available on connector builds * relax rollforward rules instead
Co-authored-by: Jedd Morgan <[email protected]>
* File Added: ConvertStructuralMaterial Separated methods pertaining to StructuralMaterial outside of the ConvertAnalyticalStick.cs file. Didn't make sense that these functions were in the ConvertAnalyticalStick.cs when the ConvertAnalyticalSurface.cs referenced them * ScaleToSpeckle Material properties were sent as revit internal units. Inconsistent with the Revit model / project units. These can't be used for connection applications (e.g. receiving analytical elements in ETABS) * ETABS Receive Property2D ETABS currently only created properties for Element2Ds with a CSIProperty2D, but what about Property2D? These should also be received without us defaulting to the "Slab1" ETABS section. * ETABS Receive Wall Property Walls were previously assigned with slab sections which is incorrect. The WallPropertyToNative() was implemented (previously raised a ConversionNotSupportedException for some reason) * RVT 22 Scaling Updates Testing on Revit 2022 - ETABS connection * Default Fallback Assign at least something to Element2D * Fixed shared project case sensitivity * IDE0005 --------- Co-authored-by: Jedd Morgan <[email protected]>
* ping should ping a static asset and add user agent headers * fix: fmt * Removed frontend headers check for FE1 servers * Removed another test that relied on this pinging --------- Co-authored-by: Dimitrie Stefanescu <[email protected]> Co-authored-by: Jedd Morgan <[email protected]>
Removed tracking for grasshopper node runs
* Optimised large queries * fix mistake
* Optimised large queries * fix mistake * fix another mistake
* fix: Dissapearing components after save SyncReceive would disappear upon opening a document (or while saving) due to exceptions being thrown in the Read/Write logic, which shouldn't ever throw. * fix: Write method for Kit name is unnecessary, dealt with in parent class
Do not assume internal storage `m_value` will exist in all GH_Goo's, some have varying implementation, but `Value` is usually consistent on all pre-rhino8 GH types
* fix(navis): Fixes missing element properties on coalesce from First Selected object. (#3651) * Correct access for const * Corrected NullParam exception signature * LINQ logic made logical * corrected correction * indent all the things * minor(navis): coalesced properties to reflect instance as dominant on duplicate (#3652) * Correct access for const * Corrected NullParam exception signature * LINQ logic made logical * corrected correction * indent all the things * First becomes Last * Limit FE1 API usage to essentials (#3662) * Updated DUI2 * remove comment subscription * Comments * fix comment * VersionUpdate subscription workaround * Dynamo * Fixed issue with collections being modified while enumerating * removed deprecated tests * Marked deprecated true on all legacy subscriptions * using directives * CNX-961 - Remove keyboard shortcuts from plugin registration (#3667) Remove keyboard shortcuts from plugin registration * fix(Revit): DirectShape Instances to Speckle Conversion support (#3572) For POC purposes - implements a fix - needs investigation * Jrm/ci fix (#3670) * Ensure CI runs on net8 * remove net 7 * bump csharpier for net8 support * ensure net8 sdk is available on connector builds * relax rollforward rules instead * Fixed email invites (#3669) * removed chunking from model class. (#3668) Co-authored-by: Jedd Morgan <[email protected]> * CNX-619 Revit Analytical Panel (#3645) * File Added: ConvertStructuralMaterial Separated methods pertaining to StructuralMaterial outside of the ConvertAnalyticalStick.cs file. Didn't make sense that these functions were in the ConvertAnalyticalStick.cs when the ConvertAnalyticalSurface.cs referenced them * ScaleToSpeckle Material properties were sent as revit internal units. Inconsistent with the Revit model / project units. These can't be used for connection applications (e.g. receiving analytical elements in ETABS) * ETABS Receive Property2D ETABS currently only created properties for Element2Ds with a CSIProperty2D, but what about Property2D? These should also be received without us defaulting to the "Slab1" ETABS section. * ETABS Receive Wall Property Walls were previously assigned with slab sections which is incorrect. The WallPropertyToNative() was implemented (previously raised a ConversionNotSupportedException for some reason) * RVT 22 Scaling Updates Testing on Revit 2022 - ETABS connection * Default Fallback Assign at least something to Element2D * Fixed shared project case sensitivity * IDE0005 --------- Co-authored-by: Jedd Morgan <[email protected]> * Revert deploy step to use .NET 6 SDK for Manager Feed (#3671) * Fix ping in SDK and add user agent headers (#3672) * ping should ping a static asset and add user agent headers * fix: fmt * Removed frontend headers check for FE1 servers * Removed another test that relied on this pinging --------- Co-authored-by: Dimitrie Stefanescu <[email protected]> Co-authored-by: Jedd Morgan <[email protected]> * Remove Node Run events from GH nodes (#3674) Removed tracking for grasshopper node runs * Ping `/api/ping` with fallbacks to older style pings (#3676) * Multi-ping * tests * adjusted timeouts * Removed favourite stream count from DUI2 stream view (#3675) * Jrm/optimise query (#3677) * Optimised large queries * fix mistake * Jrm/optimise query (#3678) * Optimised large queries * fix mistake * fix another mistake * fix: Disappearing Grasshopper components after save (#3679) * fix: Dissapearing components after save SyncReceive would disappear upon opening a document (or while saving) due to exceptions being thrown in the Read/Write logic, which shouldn't ever throw. * fix: Write method for Kit name is unnecessary, dealt with in parent class * fix(gh): Use external getter for `Value` property (#3680) Do not assume internal storage `m_value` will exist in all GH_Goo's, some have varying implementation, but `Value` is usually consistent on all pre-rhino8 GH types --------- Co-authored-by: Alan Rynne <[email protected]> Co-authored-by: Jonathon Broughton <[email protected]> Co-authored-by: Mucahit Bilal GOKER <[email protected]> Co-authored-by: Björn Steinhagen <[email protected]> Co-authored-by: Adam Hathcock <[email protected]> Co-authored-by: Dimitrie Stefanescu <[email protected]>
* fix(navis): Fixes missing element properties on coalesce from First Selected object. (#3651) * Correct access for const * Corrected NullParam exception signature * LINQ logic made logical * corrected correction * indent all the things * minor(navis): coalesced properties to reflect instance as dominant on duplicate (#3652) * Correct access for const * Corrected NullParam exception signature * LINQ logic made logical * corrected correction * indent all the things * First becomes Last * Limit FE1 API usage to essentials (#3662) * Updated DUI2 * remove comment subscription * Comments * fix comment * VersionUpdate subscription workaround * Dynamo * Fixed issue with collections being modified while enumerating * removed deprecated tests * Marked deprecated true on all legacy subscriptions * using directives * CNX-961 - Remove keyboard shortcuts from plugin registration (#3667) Remove keyboard shortcuts from plugin registration * fix(Revit): DirectShape Instances to Speckle Conversion support (#3572) For POC purposes - implements a fix - needs investigation * Jrm/ci fix (#3670) * Ensure CI runs on net8 * remove net 7 * bump csharpier for net8 support * ensure net8 sdk is available on connector builds * relax rollforward rules instead * Fixed email invites (#3669) * removed chunking from model class. (#3668) Co-authored-by: Jedd Morgan <[email protected]> * CNX-619 Revit Analytical Panel (#3645) * File Added: ConvertStructuralMaterial Separated methods pertaining to StructuralMaterial outside of the ConvertAnalyticalStick.cs file. Didn't make sense that these functions were in the ConvertAnalyticalStick.cs when the ConvertAnalyticalSurface.cs referenced them * ScaleToSpeckle Material properties were sent as revit internal units. Inconsistent with the Revit model / project units. These can't be used for connection applications (e.g. receiving analytical elements in ETABS) * ETABS Receive Property2D ETABS currently only created properties for Element2Ds with a CSIProperty2D, but what about Property2D? These should also be received without us defaulting to the "Slab1" ETABS section. * ETABS Receive Wall Property Walls were previously assigned with slab sections which is incorrect. The WallPropertyToNative() was implemented (previously raised a ConversionNotSupportedException for some reason) * RVT 22 Scaling Updates Testing on Revit 2022 - ETABS connection * Default Fallback Assign at least something to Element2D * Fixed shared project case sensitivity * IDE0005 --------- Co-authored-by: Jedd Morgan <[email protected]> * Revert deploy step to use .NET 6 SDK for Manager Feed (#3671) * Fix ping in SDK and add user agent headers (#3672) * ping should ping a static asset and add user agent headers * fix: fmt * Removed frontend headers check for FE1 servers * Removed another test that relied on this pinging --------- Co-authored-by: Dimitrie Stefanescu <[email protected]> Co-authored-by: Jedd Morgan <[email protected]> * Remove Node Run events from GH nodes (#3674) Removed tracking for grasshopper node runs * Ping `/api/ping` with fallbacks to older style pings (#3676) * Multi-ping * tests * adjusted timeouts * Removed favourite stream count from DUI2 stream view (#3675) * Jrm/optimise query (#3677) * Optimised large queries * fix mistake * Jrm/optimise query (#3678) * Optimised large queries * fix mistake * fix another mistake * fix: Disappearing Grasshopper components after save (#3679) * fix: Dissapearing components after save SyncReceive would disappear upon opening a document (or while saving) due to exceptions being thrown in the Read/Write logic, which shouldn't ever throw. * fix: Write method for Kit name is unnecessary, dealt with in parent class * fix(gh): Use external getter for `Value` property (#3680) Do not assume internal storage `m_value` will exist in all GH_Goo's, some have varying implementation, but `Value` is usually consistent on all pre-rhino8 GH types * Branch get nullabilty * fixed test warnings * Fix perf tests --------- Co-authored-by: Alan Rynne <[email protected]> Co-authored-by: Jonathon Broughton <[email protected]> Co-authored-by: Mucahit Bilal GOKER <[email protected]> Co-authored-by: Björn Steinhagen <[email protected]> Co-authored-by: Adam Hathcock <[email protected]> Co-authored-by: Dimitrie Stefanescu <[email protected]>
* Update Utils.cs * Fix formatting --------- Co-authored-by: Jedd Morgan <[email protected]>
* Populating orientationAngle CrossSectionRotation parameters of Revit analytical sticks were not assigned to Element1D.orientationAngle, hence not being received in ETABS. * Radians internal units * style(etabs): csharpier --------- Co-authored-by: Jedd Morgan <[email protected]>
- was defaullting to null since sap doesn't have the GetDesignOrientation api call
* Remove DllConflictsDetected event * Remove unused using
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.