Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding to the issue #70, MC failed due to a validation step when testing DMC module in the simulation.
Here is the DMC module we would like to try in the matsim config:
In the
base.py
file, it seems when building parameters key process, it cannot handel inputsselector:MultinomialLogit
andmodeAvailability:Car
in the DMC module with error below:I have added new conditions to handle this type of input in the
build_paramset_key
function to thebase.py
.And updated mc work fine with newly added DMC config when I test the matsim config locally using
mc debug
cli.Regarding to the issue #72, I have also updated the
load_overrides
function inautostep.py
to check for the existence of the file before attempting to open it.