Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

markdownlint -> pymarkdown #63

Merged
merged 4 commits into from
Feb 6, 2025
Merged

markdownlint -> pymarkdown #63

merged 4 commits into from
Feb 6, 2025

Conversation

brynpickering
Copy link
Collaborator

Fixes #62

This moves to using a pure python dependency for linting Markdown, to mitigate cross-platform issues when running the linter.

I've also added a windows runner to the template test CI. This won't catch everything, but would have caught this issue (as pre-commit is run on a boilerplate baked project)!

Copy link
Contributor

@Dominic-Duke Dominic-Duke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@mfitz mfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@brynpickering brynpickering merged commit 08077fd into main Feb 6, 2025
12 checks passed
@brynpickering brynpickering deleted the fix-markdown-lint branch February 6, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdownlint not installing correctly when running pre-commit
3 participants