Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSAGH-538 - read-only access to properties extensively used for testing #117

Merged
merged 9 commits into from
Sep 27, 2024

Conversation

SandeepArup
Copy link
Contributor

No description provided.

@psarras psarras marked this pull request as ready for review September 27, 2024 13:37
@psarras psarras self-requested a review September 27, 2024 13:37
@psarras psarras merged commit a928d8b into main Sep 27, 2024
3 checks passed
@psarras psarras deleted the bugfix/GSAGH-538-allow-read-only-acess branch September 27, 2024 21:46
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 85.10638% with 14 lines in your changes missing coverage. Please review.

Project coverage is 83.6%. Comparing base (625bdad) to head (3ecd235).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
OasysGH/Components/CreateOasysProfile.cs 85.4% 5 Missing and 2 partials ⚠️
OasysGH/Helpers/RhinoResolver.cs 65.0% 4 Missing and 3 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #117     +/-   ##
=======================================
- Coverage   83.7%   83.6%   -0.2%     
=======================================
  Files         50      50             
  Lines       6281    6298     +17     
  Branches     833     833             
=======================================
+ Hits        5261    5267      +6     
- Misses       790     797      +7     
- Partials     230     234      +4     
Files with missing lines Coverage Δ
GH_UnitNumber/Components/ConvertUnitNumber.cs 91.6% <100.0%> (ø)
GH_UnitNumber/Components/CreateUnitNumber.cs 97.0% <100.0%> (ø)
OasysGH/Components/GH_OasysDropDownComponent.cs 100.0% <100.0%> (ø)
OasysGH/OasysPluginInfo.cs 100.0% <ø> (ø)
OasysGH/Components/CreateOasysProfile.cs 89.7% <85.4%> (ø)
OasysGH/Helpers/RhinoResolver.cs 66.6% <65.0%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants