Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADSECGH-101: Update serviceability result component #137

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

SandeepArup
Copy link
Contributor

No description provided.

@psarras psarras requested a review from Copilot March 10, 2025 17:17
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR updates the serviceability result component by introducing new output parameters and enhancing functionality for serviceability checks. The key changes include:

  • Implementing new outputs for deformation, secant stiffness, and uncracked moment ranges.
  • Adding new parameter classes to support the updated calculations.
  • Introducing additional message lists for warnings, remarks, and errors.

Reviewed Changes

File Description
AdSecCore/Functions/SlsResulFunction.cs Adds serviceability result functionality and output updates
AdSecCore/Functions/ParametersGeneric.cs Introduces new parameter types for deformation, stiffness, and moment ranges
AdSecCore/Functions/IFunction.cs Adds message lists to support updated functional status reporting

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (2)

AdSecCore/Functions/SlsResulFunction.cs:177

  • The DeformationOutput.Value is assigned twice in Compute(), making the second assignment redundant. Consider removing the duplicate assignment on line 177.
DeformationOutput.Value = sls.Deformation;

AdSecCore/Functions/SlsResulFunction.cs:1

  • [nitpick] The file name 'SlsResulFunction.cs' appears to be missing the 't' in 'Result', which may cause confusion when matching file and class names. Consider renaming the file to 'SlsResultFunction.cs'.


@SandeepArup SandeepArup requested a review from psarras March 11, 2025 12:15
@SandeepArup SandeepArup marked this pull request as ready for review March 11, 2025 12:15
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

Attention: Patch coverage is 96.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 51.7%. Comparing base (0c7302d) to head (65a7d1f).

Files with missing lines Patch % Lines
AdSecGH/Parameters/AdSecCrackGoo.cs 63.1% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #137     +/-   ##
=======================================
+ Coverage   50.0%   51.7%   +1.7%     
=======================================
  Files        103     104      +1     
  Lines       6931    7040    +109     
  Branches     870     873      +3     
=======================================
+ Hits        3467    3643    +176     
+ Misses      3391    3324     -67     
  Partials      73      73             
Files with missing lines Coverage Δ
AdSecCore/Functions/FindCrackLoadFunction.cs 100.0% <100.0%> (ø)
AdSecCore/Functions/IFunction.cs 100.0% <100.0%> (ø)
AdSecCore/Functions/ParametersGeneric.cs 100.0% <100.0%> (ø)
AdSecCore/Functions/SlsResultFunction.cs 100.0% <100.0%> (ø)
AdSecGH/Components/6_Results/ResultsSLS.cs 83.3% <100.0%> (+35.8%) ⬆️
AdSecGH/Helpers/BusinessExtensions.cs 96.8% <100.0%> (+0.7%) ⬆️
AdSecGH/Helpers/ComponentAdapter.cs 100.0% <100.0%> (ø)
AdSecGH/Parameters/AdSecCrackGoo.cs 29.8% <63.1%> (+26.5%) ⬆️
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants