-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADSECGH-101: Update serviceability result component #137
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This PR updates the serviceability result component by introducing new output parameters and enhancing functionality for serviceability checks. The key changes include:
- Implementing new outputs for deformation, secant stiffness, and uncracked moment ranges.
- Adding new parameter classes to support the updated calculations.
- Introducing additional message lists for warnings, remarks, and errors.
Reviewed Changes
File | Description |
---|---|
AdSecCore/Functions/SlsResulFunction.cs | Adds serviceability result functionality and output updates |
AdSecCore/Functions/ParametersGeneric.cs | Introduces new parameter types for deformation, stiffness, and moment ranges |
AdSecCore/Functions/IFunction.cs | Adds message lists to support updated functional status reporting |
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (2)
AdSecCore/Functions/SlsResulFunction.cs:177
- The DeformationOutput.Value is assigned twice in Compute(), making the second assignment redundant. Consider removing the duplicate assignment on line 177.
DeformationOutput.Value = sls.Deformation;
AdSecCore/Functions/SlsResulFunction.cs:1
- [nitpick] The file name 'SlsResulFunction.cs' appears to be missing the 't' in 'Result', which may cause confusion when matching file and class names. Consider renaming the file to 'SlsResultFunction.cs'.
# Conflicts: # AdSecGH/Helpers/BusinessExtensions.cs
…opper into task/ADSECGH-101
… parameter based on unit.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #137 +/- ##
=======================================
+ Coverage 50.0% 51.7% +1.7%
=======================================
Files 103 104 +1
Lines 6931 7040 +109
Branches 870 873 +3
=======================================
+ Hits 3467 3643 +176
+ Misses 3391 3324 -67
Partials 73 73
🚀 New features to boost your workflow:
|
No description provided.