Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F/optimize floats and tensors #83

Merged
merged 7 commits into from
Jul 19, 2022
Merged

Conversation

artofnothingness
Copy link
Owner

No description provided.

@SteveMacenski
Copy link
Collaborator

SteveMacenski commented Jul 18, 2022

I'll do a deep dive tomorrow on this - do you notice this helps with the jitter and/or performance?

@artofnothingness artofnothingness force-pushed the f/optimize-floats-and-tensors branch from f151032 to 660818e Compare July 18, 2022 21:15
@artofnothingness
Copy link
Owner Author

artofnothingness commented Jul 18, 2022

I'll do a deep dive tomorrow on this - do you notice this helps with the jitter and/or performance?

looks like it. old benchmarks became 3 times faster 2.2 ms vs 0.7 ms

@SteveMacenski
Copy link
Collaborator

Heck yeah! 😄

Copy link
Collaborator

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code generally looks good, though I'm seeing a degradation in performance (e.g. robot getting stuck more, its going oddly fast).

Ex.

linear:
  x: 1.1755331754684448
  y: 0.0
  z: 0.0
angular:
  x: 0.0
  y: 0.0
  z: 0.3975425064563751

When the max is supposed to be 0.5. So I think something's not quite right. I just can't seem to find it from a look here.

I see the performance to about 13ms per iteration, which is pretty remarkable (~80hz) however I still see the spikes unfortunately. I don't think that's a reason not to still work on and merge this for the outright performance improvements though. This is still a really significant step forward from that perspective. About a 35% improvement.

I also just tested, and with these changes and after the jitter issue is resolved, we could actually back out the noise generator thread. Now the strides aren't so complex, the noises being generated inline in the main thread only adds ~2ms to the average runtime, which is still well within our desired performance

@artofnothingness artofnothingness force-pushed the f/optimize-floats-and-tensors branch from 0a4e1cc to ebd841a Compare July 19, 2022 06:21
Copy link
Collaborator

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and fixed the prior issue -- curious what that was? I went through your changes and I actually don't see even in the solution. What was it, just for my curiosity (and help tune my future reviewing skills)?

@SteveMacenski SteveMacenski merged commit 1f31869 into develop Jul 19, 2022
@SteveMacenski SteveMacenski deleted the f/optimize-floats-and-tensors branch July 19, 2022 18:26
@artofnothingness
Copy link
Owner Author

@SteveMacenski i clipped velocities and not controls )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants