Skip to content

Commit

Permalink
fix: lda next node processing condition
Browse files Browse the repository at this point in the history
  • Loading branch information
arthurhauer committed Nov 22, 2024
1 parent f1eb602 commit 365a97b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions models/node/processing/trainable/classifier/lda.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def _initialize_trainable_processor(self) -> (TransformerMixin, BaseEstimator):
:return: The initialized ``LinearDiscriminantAnalysis`` classifier.
:rtype: (TransformerMixin, BaseEstimator)
"""
return LinearDiscriminantAnalysis()
return LinearDiscriminantAnalysis(solver='lsqr', shrinkage=0.1)

@abc.abstractmethod
def _should_retrain(self) -> bool:
Expand All @@ -73,7 +73,7 @@ def _is_next_node_call_enabled(self) -> bool:
""" Checks if the next node call is enabled. In this case it checks if the processor is trained and if the
output buffer has data.
"""
return self._is_trained and self._output_buffer[self.OUTPUT_MAIN].has_data()
return self._is_trained

def _format_processed_data(self, processed_data: Any, sampling_frequency: float) -> FrameworkData:
""" Formats the processed data. In this case it creates a ``FrameworkData`` object and adds the processed data
Expand Down

0 comments on commit 365a97b

Please sign in to comment.