-
-
Notifications
You must be signed in to change notification settings - Fork 56
fix locale import for esm #664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pzmosquito
wants to merge
2
commits into
arthurdenner:develop
Choose a base branch
from
pzmosquito:feature/fix-locale-import-esm
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
import bg_BG from "./bg-BG"; | ||
import ca_ES from "./ca-ES"; | ||
import cs_CZ from "./cs-CZ"; | ||
import de_DE from "./de-DE"; | ||
import en_US from "./en-US"; | ||
import es_ES from "./es-ES"; | ||
import et_EE from "./et-EE"; | ||
import fi_FI from "./fi-FI"; | ||
import fr_FR from "./fr-FR"; | ||
import he_IL from "./he-IL"; | ||
import it_IT from './it-IT'; | ||
import ja_JP from "./ja-JP"; | ||
import ko_KR from "./ko-KR"; | ||
import nb_NO from "./nb-NO"; | ||
import nn_NO from "./nn-NO"; | ||
import pl_PL from "./pl-PL"; | ||
import pt_BR from "./pt-BR"; | ||
import ru_RU from "./ru-RU"; | ||
import sv_SE from "./sv-SE"; | ||
import tr_TR from "./tr-TR"; | ||
import zh_CN from "./zh-CN"; | ||
|
||
export default { | ||
bg_BG, | ||
ca_ES, | ||
cs_CZ, | ||
de_DE, | ||
en_US, | ||
es_ES, | ||
et_EE, | ||
fi_FI, | ||
fr_FR, | ||
he_IL, | ||
it_IT, | ||
ja_JP, | ||
ko_KR, | ||
nb_NO, | ||
nn_NO, | ||
pl_PL, | ||
pt_BR, | ||
ru_RU, | ||
sv_SE, | ||
tr_TR, | ||
zh_CN, | ||
}; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct me if I'm wrong but this would bundle all of the locales into the project, and we don't want to do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are correct that it does includes all locales. This is quickest (but not ideal) solution to make this work without needing to refactor a lot of code to accommodate dynamic import. Please feel free to close the PR and go with one of the options @wollo suggested in the issue.