fix: Autocomplete doesn't lowercase wikilink titles anymore #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| chunkState <- 1 | ||
|
|
||
| sb <- sb.Append(Char.ToLower(char)) |
Owner
There was a problem hiding this comment.
Slug is actually supposed to be lowercase. I think the change conceptually makes sense but should be implemented at a different level – I think instead of slug-ifying the completion for a wiki link title, perhaps using EncodeForWiki is enough.
Owner
|
It'd be helpful to write a test. |
artempyanykh
added
the
needs-further-input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request stops the autocomplete from turning titles in wikilinks lowercase, closing #402 .