#23557 chore(*): run rector over codebase (level 3)

rector.php

@@ -8,29 +8,49 @@
                    ->withPhpSets()
                    ->withAttributesSets(phpunit: true)
                    ->withRules([
-                                   Rector\CodeQuality\Rector\Ternary\ArrayKeyExistsTernaryThenValueToCoalescingRector::class,
-                                   Rector\CodeQuality\Rector\NullsafeMethodCall\CleanupUnneededNullsafeOperatorRector::class,
-                                   Rector\CodeQuality\Rector\ClassMethod\InlineArrayReturnAssignRector::class,
-                                   Rector\CodeQuality\Rector\Ternary\UnnecessaryTernaryExpressionRector::class,
-                                   Rector\DeadCode\Rector\Foreach_\RemoveUnusedForeachKeyRector::class,
-                                   Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictFluentReturnRector::class,
-                                   Rector\Php80\Rector\Class_\StringableForToStringRector::class,
-                                   Rector\CodingStyle\Rector\ArrowFunction\StaticArrowFunctionRector::class,
-                                   Rector\CodingStyle\Rector\Closure\StaticClosureRector::class,
-                                   Rector\DeadCode\Rector\Node\RemoveNonExistingVarAnnotationRector::class,
-                                   Rector\DeadCode\Rector\ClassMethod\RemoveUnusedPrivateMethodParameterRector::class,
-                                   Rector\TypeDeclaration\Rector\ClassMethod\BoolReturnTypeFromBooleanStrictReturnsRector::class,
-                                   Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromReturnNewRector::class,
-                                   Rector\TypeDeclaration\Rector\ClassMethod\ParamTypeByMethodCallTypeRector::class,
-                                   Rector\TypeDeclaration\Rector\ClassMethod\NumericReturnTypeFromStrictScalarReturnsRector::class,
-                                   Rector\TypeDeclaration\Rector\ClassMethod\AddMethodCallBasedStrictParamTypeRector::class,
-                                   Rector\CodeQuality\Rector\If_\ExplicitBoolCompareRector::class,
-                                   Rector\CodeQuality\Rector\Foreach_\ForeachItemsAssignToEmptyArrayToAssignRector::class,
-                                   Rector\CodeQuality\Rector\Foreach_\ForeachToInArrayRector::class,
-                                   Rector\CodeQuality\Rector\BooleanAnd\RemoveUselessIsObjectCheckRector::class,
-                               ])
+                       Rector\CodeQuality\Rector\Ternary\ArrayKeyExistsTernaryThenValueToCoalescingRector::class,
+                       Rector\CodeQuality\Rector\NullsafeMethodCall\CleanupUnneededNullsafeOperatorRector::class,
+                       Rector\CodeQuality\Rector\ClassMethod\InlineArrayReturnAssignRector::class,
+                       Rector\CodingStyle\Rector\Stmt\NewlineAfterStatementRector::class,
+                       Rector\CodingStyle\Rector\ClassMethod\NewlineBeforeNewAssignSetRector::class,
+                       Rector\Php71\Rector\BooleanOr\IsIterableRector::class,
+                       Rector\Php71\Rector\FuncCall\RemoveExtraParametersRector::class,
+                       Rector\Php73\Rector\FuncCall\JsonThrowOnErrorRector::class,
+                       Rector\TypeDeclaration\Rector\FunctionLike\AddReturnTypeDeclarationFromYieldsRector::class,
+                       Rector\TypeDeclaration\Rector\FunctionLike\AddParamTypeForFunctionLikeWithinCallLikeArgDeclarationRector::class,
+                       Rector\TypeDeclaration\Rector\FunctionLike\AddParamTypeSplFixedArrayRector::class,
+                       Rector\Php80\Rector\Catch_\RemoveUnusedVariableInCatchRector::class,
+                       Rector\Php84\Rector\Param\ExplicitNullableParamTypeRector::class,
+                       Rector\DeadCode\Rector\Foreach_\RemoveUnusedForeachKeyRector::class,
+                       Rector\DeadCode\Rector\ClassMethod\RemoveUnusedPromotedPropertyRector::class,
+                       Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictFluentReturnRector::class,
+                       Rector\Php80\Rector\Class_\StringableForToStringRector::class,
+                       Rector\CodeQuality\Rector\Ternary\UnnecessaryTernaryExpressionRector::class,
+                       Rector\CodingStyle\Rector\ArrowFunction\StaticArrowFunctionRector::class,
+                       Rector\CodingStyle\Rector\Closure\StaticClosureRector::class,
+                       Rector\DeadCode\Rector\Node\RemoveNonExistingVarAnnotationRector::class,
+                       Rector\DeadCode\Rector\ClassMethod\RemoveUnusedConstructorParamRector::class,
+                       Rector\DeadCode\Rector\Concat\RemoveConcatAutocastRector::class,
+                       Rector\DeadCode\Rector\ClassMethod\RemoveUnusedPrivateMethodParameterRector::class,
+                       Rector\Php72\Rector\FuncCall\GetClassOnNullRector::class,
+                       Rector\Php73\Rector\FuncCall\ArrayKeyFirstLastRector::class,
+                       Rector\Php80\Rector\ClassMethod\AddParamBasedOnParentClassMethodRector::class,
+                       Rector\Php80\Rector\NotIdentical\StrContainsRector::class,
+                       Rector\Php80\Rector\Identical\StrEndsWithRector::class,
+                       Rector\Php80\Rector\Identical\StrStartsWithRector::class,
+                       Rector\TypeDeclaration\Rector\ClassMethod\BoolReturnTypeFromBooleanStrictReturnsRector::class,
+                       Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromReturnNewRector::class,
+                       Rector\TypeDeclaration\Rector\ClassMethod\ParamTypeByMethodCallTypeRector::class,
+                       Rector\TypeDeclaration\Rector\ClassMethod\NumericReturnTypeFromStrictScalarReturnsRector::class,
+                       Rector\TypeDeclaration\Rector\ClassMethod\AddMethodCallBasedStrictParamTypeRector::class,
+                       Rector\CodeQuality\Rector\If_\ExplicitBoolCompareRector::class,
+                       Rector\CodeQuality\Rector\Foreach_\ForeachItemsAssignToEmptyArrayToAssignRector::class,
+                       Rector\CodeQuality\Rector\Foreach_\ForeachToInArrayRector::class,
+                       Rector\CodeQuality\Rector\BooleanAnd\RemoveUselessIsObjectCheckRector::class,
+                       Rector\CodeQuality\Rector\Class_\InlineConstructorDefaultToPropertyRector::class,
+                   ])
                    ->withPaths([
-                                   __DIR__ . '/src',
-                                   __DIR__ . '/tests',
-                               ])
-                   ->withTypeCoverageLevel(2);
+                       __DIR__ . '/src',
+                       __DIR__ . '/tests',
+                   ])
+                   ->withTypeCoverageLevel(3);

src/IP.php

@@ -13,12 +13,15 @@ class IP implements Stringable
 	use PropertyTrait;
 
 	const IP_V4 = 'IPv4';
+
 	const IP_V6 = 'IPv6';
 
 	const IP_V4_MAX_PREFIX_LENGTH = 32;
+
 	const IP_V6_MAX_PREFIX_LENGTH = 128;
 
 	const IP_V4_OCTETS = 4;
+
 	const IP_V6_OCTETS = 16;
 
 	/**
@@ -35,6 +38,7 @@ public function __construct($ip)
 		if (!filter_var($ip, FILTER_VALIDATE_IP)) {
 			throw new IpException("Invalid IP address format");
 		}
+
 		$this->in_addr = inet_pton($ip);
 	}
 
@@ -116,6 +120,7 @@ public static function parseLong($longIP, $version=self::IP_V4): self
 				$binary[] = bcmod($longIP, 256);
 				$longIP = bcdiv($longIP, 256, 0);
 			}
+
 			$ip = new self(inet_ntop(call_user_func_array('pack', array_merge(['C*'], array_reverse($binary)))));
 		}
 

src/Network.php

@@ -16,10 +16,12 @@ class Network implements \Iterator, \Countable, \Stringable
 	 * @var IP
 	 */
 	private $ip;
+
 	/**
      * @var IP
      */
 	private $netmask;
+
 	/**
 	 * @var int
 	 */

src/PropertyTrait.php

@@ -39,6 +39,7 @@ public function __set($name, $value)
 			trigger_error('Undefined property');
 			return;
 		}
+
 		$this->$method($value);
 	}
 

src/Range.php

@@ -16,10 +16,12 @@ class Range implements \Iterator, \Countable
 	 * @var IP
 	 */
 	private $firstIP;
+
 	/**
 	 * @var IP
 	 */
 	private $lastIP;
+
 	/**
 	 * @var int
 	 */