Open
Conversation
Owner
|
Thank you @robinchrist. The changes look like they make sense. I will try to look at it this week. |
artem-ogre
reviewed
Jul 14, 2025
Owner
artem-ogre
left a comment
artem-ogre
left a comment
There was a problem hiding this comment.
Mostly looks good, thank you for the effort.
Owner
|
Please rebase on top of the master. |
The conan file sets tc.cache_variables[CDT_USE_AS_COMPILED_LIBRARY], however this leads to issues because this define is not included if CDT is consumed as a dependency Additionally, the conan file used several old-style conan practices
…generator anymore
…conan center at time of writing
…ge and native CMake package The native CMake package uses CDT::CDT The autogenerated conan CMake library alias is cdt::cdt Force the library alias to CDT::CDT for backwards compat and consistency
Owner
|
Thanks for the changes! I will look at them when I get some spare time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The conan file used several old-style conan practices and has some issues.
The following changes were made:
CDT_USE_AS_COMPILED_LIBRARY: The conan file setstc.cache_variables[CDT_USE_AS_COMPILED_LIBRARY], however this leads to issues because this define is not included if CDT is consumed as a dependency. It must be set inpackage_infocpp_info.defines.appendshared,header_onlyandfPIC(This style is considered best practice and enforced for conan center recipes)I'm definitely not a conan expert, but do have some experience with it. While this conan file may not be perfect (conan experts to the rescue), it is definitely a step forward.