Skip to content

Conversation

@rhusar
Copy link
Member

@rhusar rhusar commented Jan 27, 2026

Profiles activate automatically via -Dpayara.version=6 or 7 Payara 7 requires JDK 21+ (Jakarta EE 11)

Fix archive names
Remove unnecesary cron - nothing is dynamic here, no need to retest
Fix typos

Summary by Sourcery

Add Payara 6 and 7-specific integration test profiles and update CI integration workflows accordingly.

New Features:

  • Introduce separate Maven profiles for Payara 6 and Payara 7 integration tests, activated via the payara.version property.

Enhancements:

  • Refine the shared Payara Maven profile to hold common configuration that activates automatically when payara.version is set.
  • Tighten CI matrix configuration for Payara integration tests, including explicit Payara version dimension and JDK compatibility exclusions.
  • Simplify and normalize artifact names produced by CI for WildFly and Payara integration test runs.

CI:

  • Remove the scheduled daily integration test run and keep the workflow triggered only on pushes and pull requests.
  • Reformat and clarify GitHub Actions matrices and job names for integration tests to better reflect OS, JDK, and Payara versions.

@sourcery-ai
Copy link

sourcery-ai bot commented Jan 27, 2026

Reviewer's Guide

Adds Payara 6 and Payara 7-specific Maven profiles and updates the GitHub Actions integration test workflow to drive Payara version selection via -Dpayara.version, including JDK compatibility constraints, artifact naming fixes, and removal of the scheduled cron run.

File-Level Changes

Change Details Files
Introduce separate Maven profiles for Payara 6 and Payara 7 with property-based activation and shared Payara configuration.
  • Add payara6 profile activated by payara.version=6 with Payara 6.2025.10 version and dedicated payara.home directory
  • Add payara7 profile activated by payara.version=7 with Payara 7.2026.1 version and dedicated payara.home directory
  • Refactor existing payara profile to act as common configuration that auto-activates when payara.version is set, holding shared properties and dependencies
integration-tests/pom.xml
Update Payara GitHub Actions job matrix to test Payara 6 and 7 with appropriate JDK constraints and drive Maven via -Dpayara.version.
  • Extend matrix to include payara dimension (6,7) and exclude unsupported Payara 7 combinations with Java 11 and 17 (enforce JDK 21+ requirement)
  • Change Maven invocation to pass -Dpayara.version from matrix instead of using a generic payara profile
  • Improve job and step names to include Payara version, OS, and Java version for clearer logs and reporting
.github/workflows/integration-tests.yml
Clean up workflow configuration, matrix formatting, and artifact naming for both WildFly and Payara jobs.
  • Normalize matrix definitions for OS and Java across jobs and drop unnecessary quoting for setup-java inputs
  • Rename artifact names for WildFly and Payara to a consistent ${os}-${java}-[server]-[...] pattern and fix typos in Payara artifact names
  • Remove the scheduled cron trigger so integration tests run only on pushes and pull requests
.github/workflows/integration-tests.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Profiles activate automatically via -Dpayara.version=6 or 7
Payara 7 requires JDK 21+ (Jakarta EE 11)

Fix archive names
Remove unnecesary cron - nothing is dynamic here, no need to retest

Signed-off-by: Radoslav Husar <[email protected]>
@rhusar
Copy link
Member Author

rhusar commented Jan 27, 2026

@jamezp can review this, as this is somewhat big rework.

@rhusar
Copy link
Member Author

rhusar commented Jan 27, 2026

CI is all green, neat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant