Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DO NOT MERGE: rotate default paste server due to random breakage #7542

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

DO NOT MERGE: rotate default paste server due to random breakage #7542

wants to merge 2 commits into from
+1 −1

Conversation

EvilOlaf
Copy link
Member

@EvilOlaf EvilOlaf commented Dec 6, 2024

Description

https://forum.armbian.com/topic/47932-problems-to-drive-the-gpios/#findComment-207797
Another report of might be broken main paste server.
Rotate the defaults for now.
Sent as draft, awaiting confirmation from forum thread linked above.

How Has This Been Tested?

  • hasn't

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot added size/small PR with less then 50 lines Needs review Seeking for review BSP Board Support Packages labels Dec 6, 2024
@iav
Copy link
Contributor

iav commented Dec 6, 2024

I run build with this fix, but still got

[🐳|🌿] ANSI log file built; inspect it by running: [ less -RS output/logs/log-kernel-c0db39a7-151-4755-a81e-6728702c9d3a.log.ans ]
[🐳|🌱] SHARE_LOG=yes, uploading log [ uploading logs ]
[🐳|🌿] Log uploaded, share URL: [ <!DOCTYPE html> <html lang=en> <head> <meta charset=utf-8> <tile>Error</title> </head> <body> <pre>Cannot POST /log</pre> </body> </html> ]

@EvilOlaf
Copy link
Member Author

EvilOlaf commented Dec 7, 2024

Hm. So general upload mechanism might be broken. Something must have changed elsewhere....

@iav
Copy link
Contributor

iav commented Dec 7, 2024

Looks like our script not threat the situation with server answer "Cannot POST" as error.

@iav
Copy link
Contributor

iav commented Dec 7, 2024

Sorry, ignore all my comments: I got a wrong context. I miss this about armbianmonitor, not about armbian builder.

@EvilOlaf
Copy link
Member Author

EvilOlaf commented Dec 8, 2024

It seems to affect both. My intention was to fix armbianmonitor but you mentioned that uploading the logs from a build fails with the same error.
Interestingly there was an attempt to fix http 4xx and 5xx responses by adding --fail to curl but for some reason this does not catch this new issue.

@EvilOlaf EvilOlaf changed the title rotate default paste server due to random breakage DO NOT MERGE: rotate default paste server due to random breakage Dec 8, 2024
@EvilOlaf
Copy link
Member Author

EvilOlaf commented Dec 8, 2024 •
edited
Loading

#7548 (comment) real world example for sharing logs fail.
@rpardini If you get a chance I'd appreciate if you could look into this or give some clues where to start investigating.

@rpardini
Copy link
Member

Hey folks. Indeed there's two main things sending logs to paste's:

  • armbianmonitor (supports retries, default order of retries being changed here in this PR)
  • armbian/build with SHARE_LOG=yes (lagging, does not support retries yet)

Ref the changes here: I don't think my paste server (next.) can handle being the primary. Otherwise looks good.

@EvilOlaf
Copy link
Member Author

EvilOlaf commented Jan 1, 2025

@rpardini would you mind adding the same rotation for paste servers you added here to https://github.com/armbian/build/blob/main/lib/functions/logging/export-logs.sh ? Also --fail isn't used there, I don't know if on purpose.

Lastly I setup yet another paste server using paste.armbian.eu

Just thinking: what if it chooses the server randomly? Spreading the load and if one goes down only about every fourth user hits it and then gets rotated to another one....if it fails properly :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
BSP Board Support Packages Needs review Seeking for review size/small PR with less then 50 lines
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EvilOlaf @iav @rpardini