Skip to content

Slides copy-edit#2

Open
dav-mac wants to merge 3 commits intoarm-education:mainfrom
dav-mac:main
Open

Slides copy-edit#2
dav-mac wants to merge 3 commits intoarm-education:mainfrom
dav-mac:main

Conversation

@dav-mac
Copy link
Collaborator

@dav-mac dav-mac commented Apr 1, 2025

No description provided.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attempt to answer some of your queries:

Slides, Chapter 1, Slide 12 (and 18) – Special features Row CPU Column talks about DotProd instruction set. I can’t find a specific reference to that name, but the Arm website does talk about specific SDOT and UDOT commands. Will learners know what DotProd is? Replace with Dot Product acceleration, it's a matrix operation the audience should be familiar

Slides, Chapter 1, Slide 12 – The slide shows three instances of Gb (Gigabits) but the calculation in the bullet gives an answer in GB (Gigabytes), so have updated in 3 places. Can I check the last one (Memory read/write latency) should be GB/s and not Gb/s. Notes also quote figure but use GB. All in the same unit would be preferred. Also I assume you mean slide 13?.

Slides – Learning outcomes slide on Chapter 1 (Slide 5) is styled completely differently (uses boxes) to the ones in Chapter’s 2, 3 and 4 (Bullet lists). Is this Ok or do the styles need rationalising. Please can you copy the same across all 3 sets of slides. I prefer the feel in Chapter 1

Lab1.pynb, lines 1978 and boxplot below – Both refer to Lamma3.2-1B FeedForward Layer. Should this be ‘llama’? Yes should be Llama

Lab1.pynb, lines 2021 – should ‘torch’ at the end of the line be ‘PyTorch’? Just torch, Pytorch is a wrapper around the torch library

Lab1.pynb, lines 5111 to 5152 – Are the empty code cells deliberate or should they be deleted? Please remove any empty cells, they don't do anything and are just artefacts from the content writer

Lab3.ipynb, End of ‘Graph Analysis: Thread Scaling and Bottlenecks’ and ‘Hands-On LLM Interaction’, ‘Things to Observe’ – There’s a rocket Emoji. I’ve left, but should it be there? Please remove the rocket

@kieranhejmadi01
Copy link
Contributor

Hey @Andy17MB / @dav-mac , Just realised how awkward it is to review powerpoints through github! I've responded to most of your queries. Once addressed with new commits I'll merge :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants