Exposed Stack and IsReachable properties on emitter. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@n8allan, can you provide tests for this? |
arlm
force-pushed
the
feature/Exposed_Stack_and_IsReachable
branch
from
e2db542 to
3e7df64
Compare
These are essential for consumers to know. For instance, in order to spill the stack. Without IsReachable, it is impossible for an emitter to know whether to emit instructions such as a return without doing their own redundant reachability tracking. Closes PR #4 Co-authored-by: n8allan <[email protected]>
arlm
force-pushed
the
feature/Exposed_Stack_and_IsReachable
branch
from
3e7df64 to
0118d3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are essential for consumers to know. For instance, in order to spill the stack. Without IsReachable, it is impossible for an emitter to know whether to emit instructions such as a return without doing their own redundant reachability tracking.
Closes PR #1