Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some comments #82

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion elasticsearch/schema.go
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ var index = map[string]interface{}{

// ID of the doc is:
// {orgid}-{dataset_id}-{md5 "{tsnano}-{codec_path}-{codec_key}"}
// Note: For DeleteAll the "-codec_key" is ommited
// Note: For DeleteAll the "-codec_key" is omitted
// id in elasticsearch can be 512 bytes max, so we use sha1 to hash.
// We theorically can have collision. It will unlikely happen.
// In case there is a collision, too bad, we'll have corrupted data.
Expand Down
2 changes: 1 addition & 1 deletion key/map.go
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ func (m *Map) String() string {
})
sort.Slice(kvs, func(i, j int) bool { return kvs[i].k < kvs[j].k })
var buf strings.Builder
buf.Grow(length + len("key.Map[]") + 2*len(kvs) /* room for seperators: ", :" */)
buf.Grow(length + len("key.Map[]") + 2*len(kvs) /* room for separators: ", :" */)
buf.WriteString("key.Map[")
for i, kv := range kvs {
if i != 0 {
Expand Down
2 changes: 1 addition & 1 deletion key/map_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ func TestMapEntry(t *testing.T) {
}
t.Log(m.debug())

// delete nonexistant member
// delete nonexistent member
m.Del(dumbHashable{4})
if m.Len() != 3 {
t.Errorf("expected len of 3, got %d", m.Len())
Expand Down
2 changes: 1 addition & 1 deletion sizeof/sizeof.go
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,7 @@ func sizeofChan(v reflect.Value, m map[string]uintptr, ptrsTypes map[uintptr]map
// chan map[whatEver]whatEver. In this case elemType will
// be either of type *whatEver, chan whatEver or map[whatEver]whatEver
// but what we set eface.ptr = elem above, we make it point to a pointer
// to where the data is sotred in the buffer of our channel.
// to where the data is stored in the buffer of our channel.
// So the interface tmp would look like:
// chan *whatEver -> (type=*whatEver, ptr=**whatEver)
// chan chan whatEver -> (type= chan whatEver, ptr=*chan whatEver)
Expand Down