Add support for generating lockfiles to rpmtree #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces generation of the lockfile from the rpmtree command. Following the previous patterns with the other bazel files, this adds some helper methods to bazel.go and creates a handler object to wrap this up for rpmtree. Worth noting is that to make this work we also have to tweak AddTree() to take the configuration name because the generated repos are different when using the lockfile. This change leaves the MODULE.bazel configuration up to the user as there may be some additional configuration for bazeldnf that is beyond the scope of what rpmtree is doing and we don't want to interfere with that.
(1) The error checking at the beginning isn't necessary because we also
want to support WORKSPACE mode.
(2) If we pass the default configname through to AddTree() then we'll
generate the WORKSPACE file as if we had a lock file, which is not
what we desire
wade-arista
reviewed
Jan 2, 2025
wade-arista
previously approved these changes
Jan 2, 2025
|
Haven't looked at this in very much detail |
wade-arista
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces the necessary bits for producing lockfiles using rpmtree in lieu of having to hand craft them. It also tweaks the rpmtree() invocation in the BUILD file so that it correctly points at the lockfile derived repos.