Feat(eos_cli_config_gen): Add support for mpls tunnel termination settings

[ccsnw]

Change Summary

Add knobs to configure tunnel termination settings for MPLS

Related Issue(s)

Fixes #<N/A>

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

  tunnel:
    description: Configure tunnel termination model.
    type: dict
    keys:
      termination_model:
        type: str
        description: |
          TTL and DSCP configuration as a string.
          Example:
          - "ttl pipe dscp pipe"
        valid_values:
          - "ttl pipe dscp pipe"
          - "ttl uniform dscp pipe"
          - "ttl uniform dscp uniform"
      termination_php_model:
        type: str
        description: |
          TTL and DSCP configuration as a string.
          Example:
          - "ttl pipe dscp pipe"
        valid_values:
          - "ttl pipe dscp pipe"
          - "ttl uniform dscp pipe"

How to test

added molecule test
cli command order was tested on EOS 4.30.5 - Please let me know if newer version sort differently

Checklist

User Checklist

• N/A

Repository Checklist

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation and documentation have been updated accordingly.
• I have updated molecule CI testing accordingly. (check the box if not applicable)

[github-actions]

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4888
# Activate the virtual environment
source test-avd-pr-4888/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ccsnw/ansible-avd.git@add_mpls_tunnel_termination#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ccsnw/ansible-avd.git#/ansible_collections/arista/avd/,add_mpls_tunnel_termination --force
# Optional: Install AVD examples
cd test-avd-pr-4888
ansible-playbook arista.avd.install_examples

[ClausHolbechArista]

I would like a more elaborate data model instead of all these valid values in a multi-word string. I do not know the CLI here in detail, so @ccsnw if you could provide a suggestion, we can take a look. Otherwise we can investigate more and get back.

[ccsnw]

I would like a more elaborate data model instead of all these valid values in a multi-word string. I do not know the CLI here in detail, so @ccsnw if you could provide a suggestion, we can take a look. Otherwise we can investigate more and get back.

Hi @ClausHolbechArista

Not an expert on that CLI either. Colleagues are needing it on some WAN routers.

But I noticed that the modes (php vs no php) are not mutually exclusive, so we can have sth like:

mpls tunnel termination model ttl pipe dscp pipe
mpls tunnel termination php model ttl pipe dscp pipe

in the same config.

Hence I'd suggest a model like this:

tunnel:
  termination:
    - php: < true | false >
      model:   
        ttl: < pipe | uniform >
        dscp: < pipe | uniform >

We can leave it up to the user to decide with model config makes sense (and actually is supported).

What do you think?