Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(anta.tests): Cleaning up ISIS tests module #963

Merged
merged 21 commits into from
Feb 6, 2025
Merged

fix(anta.tests): Cleaning up ISIS tests module #963

merged 21 commits into from
Feb 6, 2025
+1,020 −611

Conversation

vitthalmagadum
Copy link
Collaborator

@vitthalmagadum vitthalmagadum commented Dec 10, 2024 •
edited by carl-baillargeon
Loading

Description

Refactoring ISIS tests module to address the following issues:

Also adding proper support for different VRFs.

Tests:

  • VerifyISISNeighborCount.Input.InterfaceCount
  • VerifyISISInterfaceMode.Input.InterfaceState
  • VerifyISISSegmentRoutingAdjacencySegments.Input.IsisInstance & Segment
  • VerifyISISSegmentRoutingDataplane.Input.IsisInstance

@vitthalmagadum vitthalmagadum marked this pull request as draft December 10, 2024 18:13
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 10, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #963 will not alter performance

Comparing vitthalmagadum:fix/isis_input (37ff54c) with main (157bb9f)

Summary

✅ 22 untouched benchmarks

@vitthalmagadum vitthalmagadum mentioned this pull request Dec 12, 2024
Closed
32 tasks
@vitthalmagadum vitthalmagadum marked this pull request as ready for review December 12, 2024 05:06
carl-baillargeon
carl-baillargeon reviewed Dec 12, 2024
View reviewed changes
@gmuloc
Copy link
Collaborator

gmuloc commented Dec 20, 2024

Please add coverage

Screenshot 2024-12-20 at 14 09 13

carl-baillargeon
carl-baillargeon requested changes Jan 4, 2025
View reviewed changes
@carl-baillargeon carl-baillargeon mentioned this pull request Jan 7, 2025
Open
6 tasks
@vitthalmagadum vitthalmagadum marked this pull request as draft January 22, 2025 12:13
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@vitthalmagadum vitthalmagadum marked this pull request as ready for review January 30, 2025 04:57
@geetanjalimanegslab geetanjalimanegslab mentioned this pull request Feb 4, 2025
Closed
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 6, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
99.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

carl-baillargeon
carl-baillargeon approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Vitthal

@carl-baillargeon carl-baillargeon merged commit 6df82e7 into aristanetworks:main Feb 6, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carl-baillargeon carl-baillargeon carl-baillargeon approved these changes

@geetanjalimanegslab geetanjalimanegslab Awaiting requested review from geetanjalimanegslab

Assignees

@vitthalmagadum vitthalmagadum

Labels
rn: fix(anta.tests)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vitthalmagadum @gmuloc @carl-baillargeon