Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(anta): Added the test case to verify SNMP groups #886

Merged
merged 23 commits into from
Feb 6, 2025

Conversation

vitthalmagadum
Copy link
Collaborator

Description

Verifies the SNMP group configurations for specified version(s).

- Verifies that the valid group name and security model version.
- Ensures that the SNMP views, the read, write and notify settings aligning with version-specific requirements.

Expected Results
----------------
* Success: The test will pass if the provided SNMP group and all specified parameters are correctly configured.
* Failure: The test will fail if the provided SNMP group is not configured or specified parameters are not correctly configured.

Fixes #853

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@vitthalmagadum vitthalmagadum marked this pull request as draft October 16, 2024 18:21
Copy link
Contributor

github-actions bot commented Dec 2, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link

codspeed-hq bot commented Jan 16, 2025

CodSpeed Performance Report

Merging #886 will not alter performance

Comparing vitthalmagadum:issue_853 (eaeb329) with main (efef2c9)

Summary

✅ 22 untouched benchmarks

@geetanjalimanegslab geetanjalimanegslab marked this pull request as ready for review January 17, 2025 11:29
anta/input_models/snmp.py Outdated Show resolved Hide resolved
anta/input_models/snmp.py Outdated Show resolved Hide resolved
anta/tests/snmp.py Outdated Show resolved Hide resolved
anta/tests/snmp.py Outdated Show resolved Hide resolved
anta/tests/snmp.py Outdated Show resolved Hide resolved
gmuloc
gmuloc previously requested changes Jan 21, 2025
Copy link
Collaborator

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carl-baillargeon let us know if you disagree with splitting the error messages

anta/tests/snmp.py Outdated Show resolved Hide resolved
anta/tests/snmp.py Show resolved Hide resolved
anta/tests/snmp.py Outdated Show resolved Hide resolved
anta/tests/snmp.py Outdated Show resolved Hide resolved
anta/input_models/snmp.py Outdated Show resolved Hide resolved
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

anta/custom_types.py Outdated Show resolved Hide resolved
anta/custom_types.py Outdated Show resolved Hide resolved
Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carl-baillargeon carl-baillargeon merged commit 5780126 into aristanetworks:main Feb 6, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the test case to verify SNMP groups
4 participants