Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fix playbook tags being unconditionally passed to AVD role. #28

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ CONTAINER ?= avdteam/base:3.8-edge
VSCODE_CONTAINER ?= avdteam/vscode:latest
VSCODE_PORT ?= 8080
HOME_DIR = $(shell pwd)
AVD_COLLECTION_VERSION ?= 3.1.0
CVP_COLLECTION_VERSION ?= 3.2.0
AVD_COLLECTION_VERSION ?= 3.5.0
CVP_COLLECTION_VERSION ?= 3.3.1

help: ## Display help message
@grep -E '^[0-9a-zA-Z_-]+\.*[0-9a-zA-Z_-]+:.*?## .*$$' $(MAKEFILE_LIST) | sort | awk 'BEGIN {FS = ":.*?## "}; {printf "\033[36m%-30s\033[0m %s\n", $$1, $$2}'
Expand Down
32 changes: 14 additions & 18 deletions inventory/documentation/devices/DC1-L2LEAF1A.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
# DC1-L2LEAF1A
# Table of Contents
<!-- toc -->

- [Management](#management)
- [Management Interfaces](#management-interfaces)
Expand Down Expand Up @@ -37,7 +36,6 @@
- [VRF Instances Device Configuration](#vrf-instances-device-configuration)
- [Quality Of Service](#quality-of-service)

<!-- toc -->
# Management

## Management Interfaces
Expand Down Expand Up @@ -113,17 +111,16 @@ ntp server vrf MGMT 1.fr.pool.ntp.org

### Management API HTTP Summary

| HTTP | HTTPS |
| ---------- | ---------- |
| default | true |
| HTTP | HTTPS | Default Services |
| ---- | ----- | ---------------- |
| False | True | - |

### Management API VRF Access

| VRF Name | IPv4 ACL | IPv6 ACL |
| -------- | -------- | -------- |
| MGMT | - | - |


### Management API HTTP Configuration

```eos
Expand Down Expand Up @@ -165,14 +162,14 @@ username cvpadmin privilege 15 role network-admin secret sha512 $6$rZKcbIZ7iWGAW

| CV Compression | CloudVision Servers | VRF | Authentication | Smash Excludes | Ingest Exclude | Bypass AAA |
| -------------- | ------------------- | --- | -------------- | -------------- | -------------- | ---------- |
| gzip | 10.255.0.1:9910 | MGMT | - | ale,flexCounter,hardware,kni,pulse,strata | /Sysdb/cell/1/agent,/Sysdb/cell/2/agent | False |
| gzip | 10.255.0.1:9910 | MGMT | key, | ale,flexCounter,hardware,kni,pulse,strata | /Sysdb/cell/1/agent,/Sysdb/cell/2/agent | False |

### TerminAttr Daemon Device Configuration

```eos
!
daemon TerminAttr
exec /usr/bin/TerminAttr -cvaddr=10.255.0.1:9910 -cvvrf=MGMT -smashexcludes=ale,flexCounter,hardware,kni,pulse,strata -ingestexclude=/Sysdb/cell/1/agent,/Sysdb/cell/2/agent -taillogs
exec /usr/bin/TerminAttr -cvaddr=10.255.0.1:9910 -cvauth=key, -cvvrf=MGMT -smashexcludes=ale,flexCounter,hardware,kni,pulse,strata -ingestexclude=/Sysdb/cell/1/agent,/Sysdb/cell/2/agent -taillogs
no shutdown
```

Expand All @@ -188,9 +185,6 @@ STP mode: **mstp**
| -------- | -------- |
| 0 | 16384 |

### Global Spanning-Tree Settings


## Spanning Tree Device Configuration

```eos
Expand Down Expand Up @@ -287,9 +281,9 @@ interface Ethernet2
interface Ethernet5
description server01_Eth0
no shutdown
switchport
switchport access vlan 110
switchport mode access
switchport
```

## Port-Channel Interfaces
Expand Down Expand Up @@ -330,7 +324,8 @@ service routing protocols model multi-agent

| VRF | Routing Enabled |
| --- | --------------- |
| default | true|| MGMT | false |
| default | true |
| MGMT | false |

### IP Routing Device Configuration

Expand All @@ -345,16 +340,16 @@ no ip routing vrf MGMT

| VRF | Routing Enabled |
| --- | --------------- |
| default | false || MGMT | false |

| default | false |
| MGMT | false |

## Static Routes

### Static Routes Summary

| VRF | Destination Prefix | Next Hop IP | Exit interface | Administrative Distance | Tag | Route Name | Metric |
| --- | ------------------ | ----------------------- | ------------------- | ----------------------------- | ----------------- | ----------------------------- | -------------- |
| MGMT | 0.0.0.0/0 | 10.255.0.1 | - | 1 | - | - | - |
| MGMT | 0.0.0.0/0 | 10.255.0.1 | - | 1 | - | - | - |

### Static Routes Device Configuration

Expand All @@ -369,8 +364,9 @@ ip route vrf MGMT 0.0.0.0/0 10.255.0.1

### IP IGMP Snooping Summary

IGMP snooping is globally enabled.

| IGMP Snooping | Fast Leave | Interface Restart Query | Proxy | Restart Query Interval | Robustness Variable |
| ------------- | ---------- | ----------------------- | ----- | ---------------------- | ------------------- |
| Enabled | - | - | - | - | - |

### IP IGMP Snooping Device Configuration

Expand Down
32 changes: 14 additions & 18 deletions inventory/documentation/devices/DC1-L2LEAF2A.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
# DC1-L2LEAF2A
# Table of Contents
<!-- toc -->

- [Management](#management)
- [Management Interfaces](#management-interfaces)
Expand Down Expand Up @@ -37,7 +36,6 @@
- [VRF Instances Device Configuration](#vrf-instances-device-configuration)
- [Quality Of Service](#quality-of-service)

<!-- toc -->
# Management

## Management Interfaces
Expand Down Expand Up @@ -113,17 +111,16 @@ ntp server vrf MGMT 1.fr.pool.ntp.org

### Management API HTTP Summary

| HTTP | HTTPS |
| ---------- | ---------- |
| default | true |
| HTTP | HTTPS | Default Services |
| ---- | ----- | ---------------- |
| False | True | - |

### Management API VRF Access

| VRF Name | IPv4 ACL | IPv6 ACL |
| -------- | -------- | -------- |
| MGMT | - | - |


### Management API HTTP Configuration

```eos
Expand Down Expand Up @@ -165,14 +162,14 @@ username cvpadmin privilege 15 role network-admin secret sha512 $6$rZKcbIZ7iWGAW

| CV Compression | CloudVision Servers | VRF | Authentication | Smash Excludes | Ingest Exclude | Bypass AAA |
| -------------- | ------------------- | --- | -------------- | -------------- | -------------- | ---------- |
| gzip | 10.255.0.1:9910 | MGMT | - | ale,flexCounter,hardware,kni,pulse,strata | /Sysdb/cell/1/agent,/Sysdb/cell/2/agent | False |
| gzip | 10.255.0.1:9910 | MGMT | key, | ale,flexCounter,hardware,kni,pulse,strata | /Sysdb/cell/1/agent,/Sysdb/cell/2/agent | False |

### TerminAttr Daemon Device Configuration

```eos
!
daemon TerminAttr
exec /usr/bin/TerminAttr -cvaddr=10.255.0.1:9910 -cvvrf=MGMT -smashexcludes=ale,flexCounter,hardware,kni,pulse,strata -ingestexclude=/Sysdb/cell/1/agent,/Sysdb/cell/2/agent -taillogs
exec /usr/bin/TerminAttr -cvaddr=10.255.0.1:9910 -cvauth=key, -cvvrf=MGMT -smashexcludes=ale,flexCounter,hardware,kni,pulse,strata -ingestexclude=/Sysdb/cell/1/agent,/Sysdb/cell/2/agent -taillogs
no shutdown
```

Expand All @@ -188,9 +185,6 @@ STP mode: **mstp**
| -------- | -------- |
| 0 | 16384 |

### Global Spanning-Tree Settings


## Spanning Tree Device Configuration

```eos
Expand Down Expand Up @@ -287,9 +281,9 @@ interface Ethernet2
interface Ethernet5
description server02_Eth0
no shutdown
switchport
switchport access vlan 110
switchport mode access
switchport
```

## Port-Channel Interfaces
Expand Down Expand Up @@ -330,7 +324,8 @@ service routing protocols model multi-agent

| VRF | Routing Enabled |
| --- | --------------- |
| default | true|| MGMT | false |
| default | true |
| MGMT | false |

### IP Routing Device Configuration

Expand All @@ -345,16 +340,16 @@ no ip routing vrf MGMT

| VRF | Routing Enabled |
| --- | --------------- |
| default | false || MGMT | false |

| default | false |
| MGMT | false |

## Static Routes

### Static Routes Summary

| VRF | Destination Prefix | Next Hop IP | Exit interface | Administrative Distance | Tag | Route Name | Metric |
| --- | ------------------ | ----------------------- | ------------------- | ----------------------------- | ----------------- | ----------------------------- | -------------- |
| MGMT | 0.0.0.0/0 | 10.255.0.1 | - | 1 | - | - | - |
| MGMT | 0.0.0.0/0 | 10.255.0.1 | - | 1 | - | - | - |

### Static Routes Device Configuration

Expand All @@ -369,8 +364,9 @@ ip route vrf MGMT 0.0.0.0/0 10.255.0.1

### IP IGMP Snooping Summary

IGMP snooping is globally enabled.

| IGMP Snooping | Fast Leave | Interface Restart Query | Proxy | Restart Query Interval | Robustness Variable |
| ------------- | ---------- | ----------------------- | ----- | ---------------------- | ------------------- |
| Enabled | - | - | - | - | - |

### IP IGMP Snooping Device Configuration

Expand Down
Loading