Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update Installation guides to install community.general collection #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Update Installation guides to install community.general collection #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions INSTALLATION.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ $ make install
# Manual installation
$ ansible-galaxy collection install arista.avd:==2.0.0
$ ansible-galaxy collection install arista.cvp:==2.1.2
$ ansible-galaxy collection install community.general
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this collection? Any reason?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this repo it is needed for the callback defined in the playbook.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can simply remove the stdout yaml from the ansible.cfg, instead of adding it here to install. Let me know if this collection is adding any value? (Because I don't see any difference with out yaml output)

```

## Configure DHCP server on CloudVision
Expand Down
1 change: 1 addition & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ install-git: ## Install Ansible collections from git
install: ## Install Ansible collections
ansible-galaxy collection install arista.avd:==${AVD_COLLECTION_VERSION}
ansible-galaxy collection install arista.cvp:==${CVP_COLLECTION_VERSION}
ansible-galaxy collection install community.general

.PHONY: uninstall
uninstall: ## Remove collection from ansible
Expand Down
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ $ make shell
# Install required ansible collections
$ ansible-galaxy collection install arista.avd:==2.0.0
$ ansible-galaxy collection install arista.cvp:==2.1.2
$ ansible-galaxy collection install community.general

# Edit Inventory information & Authentication information
$ vim inventory/inventory.yml
Expand Down