feat(slack): add support for thread replies and message updates (#187) by willianpaixao · Pull Request #410 · argoproj/notifications-engine

willianpaixao · 2025-11-14T11:18:55Z

Changes:

Add threadTs field to post messages as replies in specific threads
Add updateTs field to update specific existing messages
Both fields support template expressions for dynamic values
When set, these fields override the default groupingKey/deliveryPolicy behavior
Maintain full backward compatibility with existing functionality

Implementation details:

Extended SlackNotification struct with ThreadTS and UpdateTS fields
Modified SendMessage to handle explicit thread/update timestamps
Added comprehensive tests for new features and backward compatibility
Updated documentation with usage examples and important notes

Copilot

Pull Request Overview

This PR adds support for explicit thread replies and message updates in the Slack notification service. The implementation extends the SlackNotification struct with threadTs and updateTs fields that support template expressions for dynamic values.

Key changes:

Added ThreadTS and UpdateTS fields to SlackNotification struct with template support
Modified SendMessage method to handle explicit thread/update timestamps with early-return logic
Added comprehensive test coverage for new features and backward compatibility

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
pkg/services/slack.go	Added ThreadTS and UpdateTS fields to SlackNotification struct, implemented template parsing for both fields, and updated Send method call
pkg/util/slack/client.go	Extended SendMessage signature with threadTS and updateTS parameters, implemented early-return logic for explicit timestamps
pkg/util/slack/client_test.go	Added new test functions for explicit threadTS and updateTS, refactored existing tests into backward compatibility suite, updated all SendMessage calls with new parameters
go.mod	Updated slack-go/slack from v0.16.0 to v0.17.3, updated gorilla/websocket from v1.5.0 to v1.5.3
go.sum	Updated checksums for updated dependencies
docs/services/slack.md	Added documentation section for Thread Replies and Message Updates with examples and important notes

Comments suppressed due to low confidence (1)

pkg/util/slack/client_test.go:272

The field name 'wantthreadTSs' has inconsistent capitalization. It should be 'wantThreadTSs' to follow Go naming conventions (camelCase with proper acronym capitalization).

		wantthreadTSs timestampMap

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

pkg/util/slack/client.go

ghost

Great improvement that allows a lot of use cases that currently must be done with webhooks and the slack API. Thank you!

willianpaixao · 2025-11-18T11:09:05Z

Hey @pasha-codefresh @alexmt @blakepettersson can I get a review please?

Copilot

Pull Request Overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

pkg/util/slack/client_test.go:272

The field name wantthreadTSs uses inconsistent capitalization. It should be wantThreadTSs to follow Go naming conventions (camelCase with proper capitalization of acronyms).

		wantthreadTSs timestampMap

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 9 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

pkg/util/slack/client_test.go

Copilot · 2026-01-03T08:17:38Z

pkg/util/slack/client_test.go

+func TestThreadedClient_ExplicitUpdateTS(t *testing.T) {
+	const (
+		channel   string = "channel"
+		channelID string = "channel-ID"
+		updateTS  string = "1234567890.123456"
+	)
+
+	t.Run("Explicit updateTS should update specific message", func(t *testing.T) {
+		ctrl := gomock.NewController(t)
+		defer ctrl.Finish()
+		m := mocks.NewMockSlackClient(ctrl)
+
+		// Expect an update call with channelID
+		m.EXPECT().
+			SendMessageContext(gomock.Any(), gomock.Eq(channelID), EqChatUpdate()).
+			Return("", "", "", nil)
+
+		client := NewThreadedClient(
+			m,
+			&state{
+				Limiter:    rate.NewLimiter(rate.Inf, 1),
+				ThreadTSs:  timestampMap{},
+				ChannelIDs: channelMap{channel: channelID},
+			},
+		)
+
+		// Send message with explicit updateTS
+		err := client.SendMessage(context.TODO(), channel, "", false, Post, "", updateTS, []slack.MsgOption{})
+		assert.NoError(t, err)
+	})
+}


Missing test coverage for the mutual exclusivity validation between threadTS and updateTS. The implementation at client.go:126-128 includes validation that returns an error when both fields are set, but there is no test case verifying this error condition is triggered correctly.

pkg/util/slack/client_test.go

codecov · 2026-01-03T08:35:39Z

Codecov Report

❌ Patch coverage is 68.42105% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.85%. Comparing base (da04400) to head (531d12f).
⚠️ Report is 8 commits behind head on master.

Files with missing lines	Patch %	Lines
pkg/services/slack.go	45.45%	8 Missing and 4 partials ⚠️
pkg/util/slack/client.go	82.85%	4 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #410      +/-   ##
==========================================
+ Coverage   55.41%   57.85%   +2.43%     
==========================================
  Files          46       47       +1     
  Lines        4125     4515     +390     
==========================================
+ Hits         2286     2612     +326     
- Misses       1511     1553      +42     
- Partials      328      350      +22

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…proj#187) Changes: - Add threadTs field to post messages as replies in specific threads - Add updateTs field to update specific existing messages - Both fields support template expressions for dynamic values - When set, these fields override the default groupingKey/deliveryPolicy behavior - Maintain full backward compatibility with existing functionality Implementation details: - Extended SlackNotification struct with ThreadTS and UpdateTS fields - Modified SendMessage to handle explicit thread/update timestamps - Added comprehensive tests for new features and backward compatibility - Updated documentation with usage examples and important notes Signed-off-by: Willian Paixao <willian@ufpa.br>

Signed-off-by: Willian Paixao <willian@ufpa.br>

Copilot AI review requested due to automatic review settings November 14, 2025 11:18

Copilot started reviewing on behalf of willianpaixao November 14, 2025 11:19 View session

willianpaixao mentioned this pull request Nov 14, 2025

Support Slack message updates and replies by ts #187

Open

Copilot finished reviewing on behalf of willianpaixao November 14, 2025 11:21

willianpaixao force-pushed the willianpaixao-issue-187 branch from 27d9989 to 92e3a9f Compare November 14, 2025 11:21

Copilot AI reviewed Nov 14, 2025

View reviewed changes

pkg/util/slack/client.go Show resolved Hide resolved

ghost approved these changes Nov 14, 2025

View reviewed changes

willianpaixao mentioned this pull request Nov 17, 2025

Expand Slack Trigger Capabilities argoproj/argo-events#1301

Open

willianpaixao requested a review from Copilot November 18, 2025 15:31

Copilot started reviewing on behalf of willianpaixao November 18, 2025 15:32 View session

Copilot finished reviewing on behalf of willianpaixao November 18, 2025 15:33

Copilot AI reviewed Nov 18, 2025

View reviewed changes

willianpaixao mentioned this pull request Nov 18, 2025

test: increase code coverage for templates and slack services #412

Merged

willianpaixao force-pushed the willianpaixao-issue-187 branch 3 times, most recently from 36978d3 to 1397cce Compare January 3, 2026 08:11

willianpaixao requested a review from Copilot January 3, 2026 08:12

Copilot started reviewing on behalf of willianpaixao January 3, 2026 08:12 View session

Copilot AI reviewed Jan 3, 2026

View reviewed changes

willianpaixao force-pushed the willianpaixao-issue-187 branch from 1397cce to 65974d8 Compare January 3, 2026 08:32

willianpaixao force-pushed the willianpaixao-issue-187 branch from 65974d8 to 9824dac Compare January 17, 2026 18:53

Update pkg/util/slack/client.go

531d12f

Signed-off-by: Willian Paixao <willian@ufpa.br>

willianpaixao force-pushed the willianpaixao-issue-187 branch from 9824dac to 531d12f Compare January 17, 2026 19:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(slack): add support for thread replies and message updates (#187)#410

feat(slack): add support for thread replies and message updates (#187)#410
willianpaixao wants to merge 2 commits intoargoproj:masterfrom
willianpaixao:willianpaixao-issue-187

willianpaixao commented Nov 14, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

ghost left a comment

Uh oh!

willianpaixao commented Nov 18, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Jan 3, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jan 3, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

willianpaixao commented Nov 14, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

willianpaixao commented Nov 18, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Jan 3, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jan 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Jan 3, 2026 •

edited

Loading