fix(rbac): application in any namespace inconsistent permissions#26926
Draft
agaudreault wants to merge 1 commit intoargoproj:masterfrom
Draft
fix(rbac): application in any namespace inconsistent permissions#26926agaudreault wants to merge 1 commit intoargoproj:masterfrom
agaudreault wants to merge 1 commit intoargoproj:masterfrom
Conversation
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
✅ Preview Environment deployed on Bunnyshell
See: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
10 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #26926 +/- ##
==========================================
+ Coverage 63.09% 63.15% +0.06%
==========================================
Files 414 414
Lines 56316 56466 +150
==========================================
+ Hits 35533 35662 +129
- Misses 17415 17433 +18
- Partials 3368 3371 +3 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code Changes:
appRBACName()helper and updated allcanI()calls to send namespaceCanI()method usingsecurity.RBACName()Key Behavior:
/separator, so project/* matches both formatsFixes #25289