Skip to content

fix(rbac): application in any namespace inconsistent permissions#26926

Draft
agaudreault wants to merge 1 commit intoargoproj:masterfrom
agaudreault:poc-normalized-rbac
Draft

fix(rbac): application in any namespace inconsistent permissions#26926
agaudreault wants to merge 1 commit intoargoproj:masterfrom
agaudreault:poc-normalized-rbac

Conversation

@agaudreault
Copy link
Member

@agaudreault agaudreault commented Mar 19, 2026

Code Changes:

  • UI - Added appRBACName() helper and updated all canI() calls to send namespace
  • Server - Added normalization in CanI() method using security.RBACName()
  • Tests - Added comprehensive unit and integration tests

Key Behavior:

  • Apps in default namespace: project/defaultNS/name → normalized to project/name
  • Apps in other namespaces: project/otherNS/name → kept as project/otherNS/name
  • Glob pattern * matches / separator, so project/* matches both formats

Fixes #25289

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
@bunnyshell
Copy link

bunnyshell bot commented Mar 19, 2026

✅ Preview Environment deployed on Bunnyshell

Component Endpoints
argocd https://argocd-73myum.bunnyenv.com/
argocd-ttyd https://argocd-web-cli-73myum.bunnyenv.com/

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔴 /bns:stop to stop the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@codecov
Copy link

codecov bot commented Mar 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.15%. Comparing base (382c507) to head (bb3fa07).
⚠️ Report is 27 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #26926      +/-   ##
==========================================
+ Coverage   63.09%   63.15%   +0.06%     
==========================================
  Files         414      414              
  Lines       56316    56466     +150     
==========================================
+ Hits        35533    35662     +129     
- Misses      17415    17433      +18     
- Partials     3368     3371       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AppProject RBAC Policy to get logs does not work as documented for an 'Applications in any namespace' setup

1 participant