fix(reposerver): using timeouts in http transport for Github App authentication (#26762)#26904
Draft
anandf wants to merge 2 commits intoargoproj:release-3.2from
Draft
fix(reposerver): using timeouts in http transport for Github App authentication (#26762)#26904anandf wants to merge 2 commits intoargoproj:release-3.2from
anandf wants to merge 2 commits intoargoproj:release-3.2from
Conversation
…entication (argoproj#26762) Signed-off-by: anandf <anjoseph@redhat.com>
Signed-off-by: anandf <anjoseph@redhat.com>
themavik
reviewed
Mar 19, 2026
themavik
left a comment
There was a problem hiding this comment.
This PR applies proper timeouts to the HTTP transport used for GitHub App auth by cloning DefaultTransport and using gitClientTimeout for getAccessToken.
Done well: Using http.DefaultTransport.Clone() preserves Go default timeouts. The creds.go change to use gitClientTimeout keeps behavior configurable. The new tests (TLS handshake timeout, custom timeout, dialer timeout) are thorough.
Note: The TestGitHubAppGetAccessToken_CustomTimeout test documents a known limitation: gitClientTimeout may not fully govern token requests if ghinstallation uses the transport without request context. Worth confirming the transport timeouts actually apply to the token endpoint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry pick of PR #26762
Checklist: