Skip to content

Annotation POC for syncing out of order#25903

Draft
ranakan19 wants to merge 8 commits intoargoproj:masterfrom
ranakan19:annotationPOC
Draft

Annotation POC for syncing out of order#25903
ranakan19 wants to merge 8 commits intoargoproj:masterfrom
ranakan19:annotationPOC

Conversation

@ranakan19
Copy link
Member

first stab at implementing WIP

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

…aude-code, Tests-Generated-by: cursor

Signed-off-by: Kanika Rana <krana@redhat.com>
Signed-off-by: Kanika Rana <krana@redhat.com>
Signed-off-by: Kanika Rana <krana@redhat.com>
@bunnyshell
Copy link

bunnyshell bot commented Jan 8, 2026

❌ Preview Environment undeployed from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Signed-off-by: Kanika Rana <46766610+ranakan19@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Mar 19, 2026

Codecov Report

❌ Patch coverage is 89.21569% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.21%. Comparing base (aabe852) to head (e5bc5b3).

Files with missing lines Patch % Lines
...cationset/controllers/applicationset_controller.go 89.21% 6 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #25903      +/-   ##
==========================================
+ Coverage   63.16%   63.21%   +0.04%     
==========================================
  Files         414      414              
  Lines       56461    56563     +102     
==========================================
+ Hits        35664    35754      +90     
- Misses      17427    17429       +2     
- Partials     3370     3380      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant