Skip to content

Conversation

@agaudreault
Copy link
Member

@agaudreault agaudreault commented Sep 2, 2025

Signed-off-by: Alexandre Gaudreault <[email protected]>
@bunnyshell
Copy link

bunnyshell bot commented Sep 2, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@agaudreault agaudreault changed the title chore: bump gitops-engine chore: bump gitops-engine w/ finalizer fix Sep 2, 2025
@jcogilvie
Copy link

I just hit the same UT failure in CI. to save you some time, I think this might be the fix

--- a/commitserver/commit/hydratorhelper.go
+++ b/commitserver/commit/hydratorhelper.go
@@ -71,9 +71,12 @@ func WriteForPaths(root *os.Root, repoUrl, drySha string, dryCommitMetadata *app
                        hydratePath = ""
                }

-               err = root.MkdirAll(hydratePath, 0o755)
-               if err != nil {
-                       return fmt.Errorf("failed to create path: %w", err)
+               // Only create directory if hydratePath is not empty (root directory)
+               if hydratePath != "" {
+                       err = root.MkdirAll(hydratePath, 0o755)
+                       if err != nil {
+                               return fmt.Errorf("failed to create path: %w", err)
+                       }
                }

                // Write the manifests

Not sure why it succeeded on prior runs.

@crenshaw-dev
Copy link
Member

Opened a PR with the fix: #24349

@codecov
Copy link

codecov bot commented Sep 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.21%. Comparing base (56320a7) to head (f635156).
⚠️ Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #24348      +/-   ##
==========================================
+ Coverage   60.18%   60.21%   +0.03%     
==========================================
  Files         348      348              
  Lines       59918    59918              
==========================================
+ Hits        36064    36082      +18     
+ Misses      20959    20944      -15     
+ Partials     2895     2892       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@agaudreault agaudreault marked this pull request as ready for review September 3, 2025 13:39
@agaudreault agaudreault requested a review from a team as a code owner September 3, 2025 13:39
@agaudreault agaudreault merged commit 871b0b4 into argoproj:master Sep 3, 2025
28 checks passed
@Whisper40
Copy link

Whisper40 commented Sep 5, 2025

@crenshaw-dev Will it be cherrypicked for release 3.0 soon ? Thanks

Mangaal pushed a commit to Mangaal/argo-cd that referenced this pull request Sep 10, 2025
Signed-off-by: Alexandre Gaudreault <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Mangaal <[email protected]>
akhilsingh-git pushed a commit to akhilsingh-git/argo-cd that referenced this pull request Sep 11, 2025
Signed-off-by: Alexandre Gaudreault <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Akhil Singh <[email protected]>
downfa11 pushed a commit to downfa11/argo-cd that referenced this pull request Sep 12, 2025
Signed-off-by: Alexandre Gaudreault <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
sivasath16 pushed a commit to sivasath16/argo-cd that referenced this pull request Sep 17, 2025
Signed-off-by: Alexandre Gaudreault <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
sivasath16 pushed a commit to sivasath16/argo-cd that referenced this pull request Sep 17, 2025
Signed-off-by: Alexandre Gaudreault <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants