-
Notifications
You must be signed in to change notification settings - Fork 6.6k
chore: bump gitops-engine w/ finalizer fix #24348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump gitops-engine w/ finalizer fix #24348
Conversation
Signed-off-by: Alexandre Gaudreault <[email protected]>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
|
I just hit the same UT failure in CI. to save you some time, I think this might be the fix Not sure why it succeeded on prior runs. |
|
Opened a PR with the fix: #24349 |
Signed-off-by: Alexandre Gaudreault <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24348 +/- ##
==========================================
+ Coverage 60.18% 60.21% +0.03%
==========================================
Files 348 348
Lines 59918 59918
==========================================
+ Hits 36064 36082 +18
+ Misses 20959 20944 -15
+ Partials 2895 2892 -3 ☔ View full report in Codecov by Sentry. |
|
@crenshaw-dev Will it be cherrypicked for release 3.0 soon ? Thanks |
Signed-off-by: Alexandre Gaudreault <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]> Signed-off-by: Mangaal <[email protected]>
Signed-off-by: Alexandre Gaudreault <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]> Signed-off-by: Akhil Singh <[email protected]>
Signed-off-by: Alexandre Gaudreault <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Alexandre Gaudreault <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Alexandre Gaudreault <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]>
Deploys argoproj/gitops-engine#770