Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Argilla frontend: Add default OAuth button #5695

Conversation

frascuchon
Copy link
Member

Description

This PR adds logic to the sign-in page to include a default OAuth provider button. So, users can sign using whatever provider is defined.

Refs #5689

Type of change

  • Improvement (change adding some improvement to an existing functionality)
  • Documentation update

How Has This Been Tested

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@frascuchon frascuchon changed the base branch from develop to refactor/argilla-server/better-oauth2-integration November 19, 2024 14:31
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.39%. Comparing base (8700b81) to head (cee0e38).
Report is 5 commits behind head on refactor/argilla-server/better-oauth2-integration.

Additional details and impacted files
@@                                  Coverage Diff                                  @@
##           refactor/argilla-server/better-oauth2-integration    #5695      +/-   ##
=====================================================================================
+ Coverage                                              90.94%   91.39%   +0.45%     
=====================================================================================
  Files                                                    148      163      +15     
  Lines                                                   6237     6662     +425     
=====================================================================================
+ Hits                                                    5672     6089     +417     
- Misses                                                   565      573       +8     
Flag Coverage Δ
argilla-server 91.39% <ø> (+0.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

The URL of the deployed environment for this PR is https://argilla-quickstart-pr-5695-ki24f765kq-no.a.run.app

@frascuchon frascuchon added the area: ui Indicates that an issue or pull request is related to the User Interface (UI) label Nov 19, 2024
@frascuchon frascuchon merged commit a481482 into refactor/argilla-server/better-oauth2-integration Nov 20, 2024
4 checks passed
@frascuchon frascuchon deleted the argilla-frontend/add-default-oauth-button branch November 20, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ui Indicates that an issue or pull request is related to the User Interface (UI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants