-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New feature Auto Clear Remote Temp for MiElHVAC #22370
Conversation
Add Prohibit functions: * Power * Temperature * Mode and all combinations of this functions Updated VaneV names for better identify
Changed Widevane position name from ISEE to AUTO sam as in MELCLoud
This reverts commit f0973c8.
* Added Compressor map * Added Operation Power in Watts * Added Operation Energy in kWh * Changed Widevane position name from ISEE to AUTO, displays sam as in * Changed all map value to lover case MELCloud
* Add device operation time in minutes
* Add Outdoor Temperature
* Added Outdoor Temperature * Renamed internal properties due typo operating and oprating to operation
* This PR add auto clear remote temperature function * This funcion is call on first run and after 10 sec the remote temperature stop refresh its value * Send manually Clear command is also available
I think 10sec are not enough. Maybe set the time to follow teleperiod ? Or 60 sec are more realistic |
Why is not realistic? you can call Remote Temp every 1 sec or quickly. |
I mean realistic for an Hvac operation… the shortest time i think should be >30sec. No need to send remote temp less than 10-15 sec |
10 sec is very long time, the microcontroller respond time is in milliseconds. Where You see the problem to send data for example every 5 sec. I think the data need to be operated as quickly as possible. |
Ok. Let imagine 2 scenarios:
|
I use PLC to communicate with my microcontrollers, the 10sec is very long time where my loop in code is 7ms. Update data every few seconds is not a problem and also is nothing for CPU load. I don’t understand where is the problem, You can send the Remote Temp every 1sec, 2sec, 500ms etc. This technically is not a problem. |
Many users use wifi/mqtt… Would be ok only a check in the mqtt loop if there is disconnection from the mqtt server? |
Also in looked at mitsubishi2mqtt project and the time is set at 5 minutes ! (lines ~ 1350) https://github.com/gysmo38/mitsubishi2MQTT/blob/master/src/mitsubishi2mqtt/mitsubishi2mqtt.ino |
This is wrong, in 5min the temp can changed from 20 to 25 grad. What happened if set temp is set to 23? nothing, just heating because the remote temp was not refreshed. |
I do agree that in some situations the 5min is too long but also in some situations the 10sec is too short. :) |
What is the benefit to get longer time? |
I can make the auto clear time configurable but I have not enough skill with Tasmota to store it in non-volatile memory. In other case will always revert to default after restart. May be someone can help. |
Make it a command. This can then be used in a persistent rule during restart/boot and set the desired parameter like it was persistent. This way no additional resources are needed. |
* Add prohibit function for MiElHVAC Add Prohibit functions: * Power * Temperature * Mode and all combinations of this functions Updated VaneV names for better identify * Fixed Compressor and Operation for MiElHVAC Changed Widevane position name from ISEE to AUTO sam as in MELCLoud * Revert "Fixed Compressor and Operation for MiElHVAC" This reverts commit f0973c8. * New feature for MiElHVAC * Added Compressor map * Added Operation Power in Watts * Added Operation Energy in kWh * Changed Widevane position name from ISEE to AUTO, displays sam as in * Changed all map value to lover case MELCloud * New feature for MiElHVAC * Add device operation time in minutes * New feature Outdoor Temperature for MiElHVAC * Add Outdoor Temperature * New feature Compressor Frequency for MiElHVAC * Added Outdoor Temperature * Renamed internal properties due typo operating and oprating to operation * New feature Auto Clear Remote Temp for MiElHVAC * This PR add auto clear remote temperature function * This funcion is call on first run and after 10 sec the remote temperature stop refresh its value * Send manually Clear command is also available * change function name, small corrections * added auto clear time configurable using cmnd
* Add prohibit function for MiElHVAC Add Prohibit functions: * Power * Temperature * Mode and all combinations of this functions Updated VaneV names for better identify * Fixed Compressor and Operation for MiElHVAC Changed Widevane position name from ISEE to AUTO sam as in MELCLoud * Revert "Fixed Compressor and Operation for MiElHVAC" This reverts commit f0973c8. * New feature for MiElHVAC * Added Compressor map * Added Operation Power in Watts * Added Operation Energy in kWh * Changed Widevane position name from ISEE to AUTO, displays sam as in * Changed all map value to lover case MELCloud * New feature for MiElHVAC * Add device operation time in minutes * New feature Outdoor Temperature for MiElHVAC * Add Outdoor Temperature * New feature Compressor Frequency for MiElHVAC * Added Outdoor Temperature * Renamed internal properties due typo operating and oprating to operation * New feature Auto Clear Remote Temp for MiElHVAC * This PR add auto clear remote temperature function * This funcion is call on first run and after 10 sec the remote temperature stop refresh its value * Send manually Clear command is also available * change function name, small corrections * added auto clear time configurable using cmnd
Description:
10sec
after the remote temperature stop updating its valueclear
manually is also available10000ms
, can be changed with commandHVACRemoteTempClearTime
Related issue (if applicable): fixes #22365
Checklist:
NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass