Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feature Auto Clear Remote Temp for MiElHVAC #22370

Merged
merged 25 commits into from
Oct 28, 2024

Conversation

grzegorz914
Copy link
Contributor

@grzegorz914 grzegorz914 commented Oct 27, 2024

Description:

  • This PR add auto clear remote temperature function
  • This function is called on first run and also 10sec after the remote temperature stop updating its value
  • Send clear manually is also available
  • The auto clear time is in (ms), default is 10000ms, can be changed with command HVACRemoteTempClearTime

Related issue (if applicable): fixes #22365

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.8
  • The code change is tested and works with Tasmota core ESP32 V.3.1.0.241023
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

Add Prohibit functions:
* Power
* Temperature
* Mode
 and all combinations of this functions
Updated VaneV names for better identify
Changed Widevane position name from ISEE to AUTO sam as in MELCLoud
* Added Compressor map
* Added Operation Power in Watts
* Added Operation Energy in kWh
* Changed Widevane position name from ISEE to AUTO, displays sam as in
* Changed all map value to lover case MELCloud
* Add device operation time in minutes
* Added Outdoor Temperature
* Renamed internal properties due typo operating and oprating to operation
* This PR add auto clear remote temperature function
* This funcion is call on first run and after 10 sec the remote temperature stop refresh its value
* Send manually Clear command is also available
@mamrai1
Copy link

mamrai1 commented Oct 27, 2024

I think 10sec are not enough. Maybe set the time to follow teleperiod ? Or 60 sec are more realistic

@grzegorz914
Copy link
Contributor Author

Why is not realistic? you can call Remote Temp every 1 sec or quickly.

@mamrai1
Copy link

mamrai1 commented Oct 27, 2024

I mean realistic for an Hvac operation… the shortest time i think should be >30sec. No need to send remote temp less than 10-15 sec

@grzegorz914
Copy link
Contributor Author

10 sec is very long time, the microcontroller respond time is in milliseconds. Where You see the problem to send data for example every 5 sec. I think the data need to be operated as quickly as possible.

@mamrai1
Copy link

mamrai1 commented Oct 28, 2024

Ok. Let imagine 2 scenarios:

  1. The remote temperature sensor is on the same microcontroller: yes 10 sec is more than enough but
  2. The remote temperature sensor is on another controller (in the same room of course) and sends the data via the mqtt server or directly on the controller on the unit: it does make sense to send the readings at teleperiod ….

@grzegorz914
Copy link
Contributor Author

I use PLC to communicate with my microcontrollers, the 10sec is very long time where my loop in code is 7ms. Update data every few seconds is not a problem and also is nothing for CPU load. I don’t understand where is the problem, You can send the Remote Temp every 1sec, 2sec, 500ms etc. This technically is not a problem.

@grzegorz914 grzegorz914 marked this pull request as draft October 28, 2024 06:24
@mamrai1
Copy link

mamrai1 commented Oct 28, 2024

Many users use wifi/mqtt… Would be ok only a check in the mqtt loop if there is disconnection from the mqtt server?

@mamrai1
Copy link

mamrai1 commented Oct 28, 2024

Also in looked at mitsubishi2mqtt project and the time is set at 5 minutes ! (lines ~ 1350)

https://github.com/gysmo38/mitsubishi2MQTT/blob/master/src/mitsubishi2mqtt/mitsubishi2mqtt.ino

@grzegorz914
Copy link
Contributor Author

This is wrong, in 5min the temp can changed from 20 to 25 grad. What happened if set temp is set to 23? nothing, just heating because the remote temp was not refreshed.

@mamrai1
Copy link

mamrai1 commented Oct 28, 2024

I do agree that in some situations the 5min is too long but also in some situations the 10sec is too short. :)

@grzegorz914
Copy link
Contributor Author

grzegorz914 commented Oct 28, 2024

What is the benefit to get longer time?
Why the 10sec time is not OK?, for me shorter time is always better because get more real time data to the device.

@grzegorz914 grzegorz914 marked this pull request as ready for review October 28, 2024 10:35
@grzegorz914
Copy link
Contributor Author

I can make the auto clear time configurable but I have not enough skill with Tasmota to store it in non-volatile memory. In other case will always revert to default after restart. May be someone can help.

@arendst
Copy link
Owner

arendst commented Oct 28, 2024

Make it a command.

This can then be used in a persistent rule during restart/boot and set the desired parameter like it was persistent.

This way no additional resources are needed.

@arendst arendst merged commit 27db263 into arendst:development Oct 28, 2024
59 checks passed
josef109 pushed a commit to josef109/Tasmota that referenced this pull request Nov 7, 2024
* Add prohibit function for MiElHVAC

Add Prohibit functions:
* Power
* Temperature
* Mode
 and all combinations of this functions
Updated VaneV names for better identify

* Fixed Compressor and Operation for MiElHVAC

Changed Widevane position name from ISEE to AUTO sam as in MELCLoud

* Revert "Fixed Compressor and Operation for MiElHVAC"

This reverts commit f0973c8.

* New feature for MiElHVAC

* Added Compressor map
* Added Operation Power in Watts
* Added Operation Energy in kWh
* Changed Widevane position name from ISEE to AUTO, displays sam as in
* Changed all map value to lover case MELCloud

* New feature for MiElHVAC

* Add device operation time in minutes

* New feature Outdoor Temperature for MiElHVAC

* Add Outdoor Temperature

* New feature Compressor Frequency for MiElHVAC

* Added Outdoor Temperature
* Renamed internal properties due typo operating and oprating to operation

* New feature Auto Clear Remote Temp for MiElHVAC

* This PR add auto clear remote temperature function
* This funcion is call on first run and after 10 sec the remote temperature stop refresh its value
* Send manually Clear command is also available

* change function name, small corrections

* added auto clear time configurable using cmnd
josef109 pushed a commit to josef109/Tasmota that referenced this pull request Nov 10, 2024
* Add prohibit function for MiElHVAC

Add Prohibit functions:
* Power
* Temperature
* Mode
 and all combinations of this functions
Updated VaneV names for better identify

* Fixed Compressor and Operation for MiElHVAC

Changed Widevane position name from ISEE to AUTO sam as in MELCLoud

* Revert "Fixed Compressor and Operation for MiElHVAC"

This reverts commit f0973c8.

* New feature for MiElHVAC

* Added Compressor map
* Added Operation Power in Watts
* Added Operation Energy in kWh
* Changed Widevane position name from ISEE to AUTO, displays sam as in
* Changed all map value to lover case MELCloud

* New feature for MiElHVAC

* Add device operation time in minutes

* New feature Outdoor Temperature for MiElHVAC

* Add Outdoor Temperature

* New feature Compressor Frequency for MiElHVAC

* Added Outdoor Temperature
* Renamed internal properties due typo operating and oprating to operation

* New feature Auto Clear Remote Temp for MiElHVAC

* This PR add auto clear remote temperature function
* This funcion is call on first run and after 10 sec the remote temperature stop refresh its value
* Send manually Clear command is also available

* change function name, small corrections

* added auto clear time configurable using cmnd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MiElHVAC Remote Temp and reverting to internal temp
3 participants