Bump github.com/olekukonko/tablewriter from 0.0.5 to 1.0.5 in /ruledocsgen#877
Conversation
Bumps [github.com/olekukonko/tablewriter](https://github.com/olekukonko/tablewriter) from 0.0.5 to 1.0.5. - [Commits](olekukonko/tablewriter@v0.0.5...v1.0.5) --- updated-dependencies: - dependency-name: github.com/olekukonko/tablewriter dependency-version: 1.0.5 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #877 +/- ##
==========================================
+ Coverage 89.97% 90.12% +0.14%
==========================================
Files 44 43 -1
Lines 6772 6610 -162
==========================================
- Hits 6093 5957 -136
+ Misses 555 538 -17
+ Partials 124 115 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
per1234
left a comment
per1234
left a comment
There was a problem hiding this comment.
I haven't done a thorough check, but I believe that this version does meet the requirements of the github.com/arduino/arduino-lint/ruledocsgen module (once the code has been adjusted for the breaking changes introduced in version 1.0.0).
However, it does not meet the requirements of the github.com/arduino/arduino-lint module (see #876 (review)).
Because there are significant differences between the 0.x and 1.x versions of github.com/olekukonko/tablewriter, I think it is better to use a consistent version throughout the Arduino Lint project. So I will put this on hold until the relevant regressions introduced in 1.0.0 have been resolved and we can bump the dependency in both modules.
per1234
added
type: enhancement
|
Superseded by #879. |
dependabot
Bot
deleted the
dependabot/go_modules/ruledocsgen/github.com/olekukonko/tablewriter-1.0.5
branch
per1234
added
conclusion: duplicate
1 participant
Bumps github.com/olekukonko/tablewriter from 0.0.5 to 1.0.5.
Commits
88e7330Merge pull request #250 from olekukonko/csv2512aa1improving symbols567f985add more symbols2d6c558avoid debug formating as possiblef91b836remove extra conversion8dfe851centralize t.Trimer & WrapStringWithSpaces Update #2543ff1edeSteal Some performance6137423add support forReset3d937adresolving #252 with extra protection0d0a462improved csv2table #251Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)