-
Notifications
You must be signed in to change notification settings - Fork 7
Pin the major platform/core version for updates #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
8b0899e to
98440c3
Compare
d8edeb0 to
53eedc0
Compare
lucarin91
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check out the comment below; in that way, we could simplify the code and take full advantage of the semver library.
We should then check that the installation operation on the Arduino platform will behave like the upgrade. For doing that, we could manually install an old version of the platform and then try to upgrade it with the app-cli command or with the http api. For instance, something like
arduino-cli core uninstall arduino:zephyr
arduino-cli core install arduino:[email protected]
arduino-app-cli system update
After that, we should have again zephyr 0.52.0 (the last version up to today)
test on board : passed
final result: |
Motivation
closes #738
The logic that updates the platform should make sure we do not upgrade above the 1.x.x release.
In other words there should be a variable specifying the maximum major version that will be reported as an update.
This is to avoid auto-updating to a breaking change.>
Change description
Additional Notes
Reviewer checklist
main.