Allow customization of transmit and receive buffer sizes for I2C 'Wire' and 'Wire1' objects. #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wire and Wire1 use WireBuffer.
Use size_t in for loop instead of uin8_t. Added override specifier where applicable. Changed const to constexpr where possible. Added const qualifiers where possible.
speed and less code size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request for the SAM architecture corresponds to pull request #589 for the AVR architecture.
When I had the need for a bigger Wire buffer, I came up with this implementation.
Existing sketches work like before, but just with one additional macro in the sketch, Wire will get smaller or larger buffers and will omit unnecessary buffers when possible. E.g. the receive buffer will be omitted when no receive is required. There are six example sketches available, that demonstrate how the macro works and give evidence about the customization of the buffer sizes.
Wire buffers are still allocated at compile time.
Both TwoWire objects Wire and Wire1 are supported.
There is also some refactoring done in regard to using C++ casts instead of C casts, making some functions inline for speed and code size.