Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C33 Ethernet fix warnings #440

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+9 −11
Open

C33 Ethernet fix warnings #440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a073024
CEthernet: suppress unused variable warning
pennam Feb 13, 2025
c36e24a
EthernetDriver: remove line with no effect
pennam Feb 13, 2025
c439b6e
EthernetClock: fix stop() logic to avoid missing return value warning
pennam Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions libraries/Ethernet/src/Ethernet.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,8 @@ int CEthernet::begin(uint8_t *mac_address, IPAddress local_ip, IPAddress dns_ser
/* -------------------------------------------------------------------------- */
int CEthernet::begin(uint8_t *mac, IPAddress local_ip, IPAddress dns_server, IPAddress gateway, IPAddress subnet, unsigned long timeout, unsigned long responseTimeout) {
/* -------------------------------------------------------------------------- */
(void)responseTimeout;
(void)timeout;
CLwipIf::getInstance().setMacAddress(NI_ETHERNET, mac);
return begin(local_ip, dns_server, gateway, subnet);
}
Expand Down
17 changes: 7 additions & 10 deletions libraries/Ethernet/src/EthernetClock.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,17 +49,14 @@ fsp_err_t EthernetClock::stop() {
fsp_err_t err = R_AGT_Stop(&this->TIMER_ETHERNET_ctrl);
if (err != FSP_SUCCESS) {
return err;
} else {
err = R_AGT_Close(&this->TIMER_ETHERNET_ctrl);
if (err != FSP_SUCCESS) {
return err;
} else {
err = R_AGT_Disable(&this->TIMER_ETHERNET_ctrl);
if (err != FSP_SUCCESS) {
return err;
}
}
}

err = R_AGT_Close(&this->TIMER_ETHERNET_ctrl);
if (err != FSP_SUCCESS) {
return err;
}

return R_AGT_Disable(&this->TIMER_ETHERNET_ctrl);
}

#else
Expand Down
1 change: 0 additions & 1 deletion libraries/Ethernet/src/EthernetDriver.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,6 @@ void eth_reset_due_to_ADE_bit() {
/* -------------------------------------------------------------------------- */
void EthernetDriver::irq_callback(ether_callback_args_t * p_args) {
/* -------------------------------------------------------------------------- */
p_args->status_ecsr;
uint32_t reg_eesr = p_args->status_eesr;
if(p_args->channel == ETHERNET_CHANNEL) {
if(p_args->event == ETHER_EVENT_WAKEON_LAN) {
Expand Down
Loading