Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WiFiS3 and WiFIC3 Add wl definitions #439

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pennam
Copy link
Contributor

@pennam pennam commented Feb 13, 2025

Fixes: #294

I've added only WL*_LENGTH definitions because even though they are mostly unused they are handy to declare arrays as explained in the issue.

@pennam pennam changed the title Add wl definitions WiFiS3 and WiFIC3 Add wl definitions Feb 13, 2025
@pennam pennam requested a review from maidnl February 13, 2025 11:46
Copy link
Contributor

@maidnl maidnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 wrong comments to be reviewed

#define WL_WEP_KEY_MAX_LENGTH 13
// Size of a MAC-address or BSSID
#define WL_MAC_ADDR_LENGTH 6
// Size of a MAC-address or BSSID
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Size of a MAC-address or BSSID
// Size of a IP4 address

#define WL_MAC_ADDR_LENGTH 6
// Size of a MAC-address or BSSID
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Size of a MAC-address or BSSID
// Size of a IP4 address

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WL Definitions Missing
3 participants