Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ping command #1014

Merged
merged 4 commits into from
Feb 5, 2025
Merged

Ping command #1014

merged 4 commits into from
Feb 5, 2025

Conversation

fabik111
Copy link
Contributor

@fabik111 fabik111 commented Jan 8, 2025

This PR adds the Ping command to SocketHelpers making it available from all the IP network interfaces (WiFi, Ethernet, CatM1...).

The method signature is:

  int ping(const char* hostname, uint8_t ttl = 128);
  int ping(const String& hostname, uint8_t ttl = 128);
  int ping(IPAddress host, uint8_t ttl = 128);

@pennam
Copy link
Contributor

pennam commented Feb 4, 2025

Force pushed to fix conflicts and rebase on master. Other changes squashed in the first commit:

  • Add comments about ttl
  • Remove RP2040 changes in json file

Added patch with ICMPSocket ping. We need to move ping implementation inside libmbed to avoid adding lwIP include paths to the build. lwIP paths were intentionally removed to avoid clashes in non case sensitive systems.

de1baab

Adapt SocketHelpers ping to use ICMPSocket ping

@pennam
Copy link
Contributor

pennam commented Feb 5, 2025

Board Eth WiFi
OPTA 👍 👍
H7 👍 👍
GIGA NA 👍
NV NA 👍

@pennam pennam requested a review from facchinm February 5, 2025 07:53
@pennam pennam merged commit d00befa into arduino:main Feb 5, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants