Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce nsapi dns response timeout: 5 seconds 3 retires #1009

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

fabik111
Copy link
Contributor

Currently the nsapi is configured with a default value of 10s of timeout and with 10 attempts before failure.
In case internet is not available (but the board is correctly connected to the AP), with this set of parameters the sketch is waiting for 100 s stopping the main loop. If you are using an ArduinoIoTCloud sketch the board is rebooted by the watchdog timer

@fabik111 fabik111 marked this pull request as ready for review January 7, 2025 09:33
Copy link
Contributor

@pennam pennam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabik111 the changes for the RP2040 and the GENERIC_STM32H7_M4 variant should be removed.

RP2040 uses WiFiNINA, and the M4 variant does not support networking.

@fabik111 fabik111 requested a review from pennam January 20, 2025 16:19
@pennam
Copy link
Contributor

pennam commented Jan 29, 2025

@fabik111 according to this i would feel more safe increasing the timeout to 5s and reducing the number of retries to 3.
Also windows dnslookup and linux host command are using a default timeout of 5 seconds

@pennam pennam changed the title Reduce nsapi dns response timeout to 2s Reduce nsapi dns response timeout: 5 seconds 3 retires Jan 31, 2025
@pennam pennam force-pushed the reduce-dns-timeout branch 2 times, most recently from a778488 to eb3a59a Compare January 31, 2025 11:02
@pennam
Copy link
Contributor

pennam commented Jan 31, 2025

Removed also edge control and squashed changes

@pennam pennam force-pushed the reduce-dns-timeout branch from eb3a59a to 1601545 Compare January 31, 2025 11:06
@pennam pennam merged commit 6fc83c8 into arduino:main Jan 31, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants