-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Wire: Fix write() returning incorrect byte count on buffer overflow (See issue #597) #612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Tranomial
wants to merge
2
commits into
arduino:master
Choose a base branch
from
Tranomial:WireWriteFix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Memory usage change @ a87cc4c
Click for full report table
Click for full report CSV |
|
Memory usage change @ 4a0324a
Click for full report table
Click for full report CSV |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wire.write() previously returned the number of bytes requested, even if the
internal 32-byte transmission buffer could not store all of them. This caused
code that paged or chunked writes to prematurely terminate, and silently drop
data.
The function now returns the actual number of bytes appended to the TX buffer,
matching the standard Arduino Wire API behavior and allowing callers to detect
buffer limits correctly.
Fixes #597.